Page MenuHomeFreeBSD
Differential D27563

fdgrowtable_test.c: appease gcc
ClosedPublic
Actions

Authored by rlibby on Dec 10 2020, 10:23 PM.
Tags
None
Referenced Files
F112691628: D27563.id80622.diff
Fri, Mar 21, 12:31 PM
Unknown Object (File)
Tue, Mar 18, 12:11 AM
Unknown Object (File)
Sun, Mar 16, 4:27 PM
Unknown Object (File)
Tue, Mar 11, 9:39 AM
Unknown Object (File)
Thu, Feb 20, 10:42 PM
Unknown Object (File)
Thu, Feb 20, 10:35 PM
Unknown Object (File)
Thu, Feb 20, 10:19 PM
Unknown Object (File)
Feb 19 2025, 4:12 AM
View All 77 Files
Subscribers
imp

Details

Reviewers
kevans
rew
Commits
rS368569: fdgrowtable_test.c: appease gcc
Summary

Work around bogus gcc -Wreturn-type.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44511

Test Plan
env MAKEOBJDIRPREFIX=/usr/obj/gcc6 CROSS_TOOLCHAIN=amd64-gcc make buildworld
env MAKEOBJDIRPREFIX=/usr/obj/clang make buildworld

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35333
Build 32262: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 10 2020, 10:23 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 10 2020, 10:23 PM
rlibby requested review of this revision.Dec 10 2020, 10:23 PM
Harbormaster completed remote builds in B35330: Diff 80564.Dec 10 2020, 10:23 PM
rew added a comment.Dec 10 2020, 11:00 PM

Looks good.

tests/sys/kern/fdgrowtable_test.c
154

maybe static _Noreturn void *?

rew accepted this revision.Dec 10 2020, 11:00 PM
This revision is now accepted and ready to land.Dec 10 2020, 11:00 PM
rlibby updated this revision to Diff 80567.Dec 10 2020, 11:08 PM

rew feedback: reorder keywords

This revision now requires review to proceed.Dec 10 2020, 11:08 PM
Harbormaster completed remote builds in B35333: Diff 80567.Dec 10 2020, 11:08 PM
rew accepted this revision.Dec 10 2020, 11:12 PM
This revision is now accepted and ready to land.Dec 10 2020, 11:12 PM
kevans accepted this revision.Dec 10 2020, 11:14 PM
Closed by commit rS368569: fdgrowtable_test.c: appease gcc (authored by rlibby). · Explain WhyDec 11 2020, 10:53 PM
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rS368569: fdgrowtable_test.c: appease gcc.

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
2 lines

Diff 80567

View Options

tests/sys/kern/fdgrowtable_test.c

Loading...