Paths

Table of Contentst

Differential D27450

ipfw kfib algo: Use rt accessors instead of accessing rib/rtentry directly.
ClosedPublic
Actions

Authored by melifaro on Dec 2 2020, 10:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 8:56 PM

	Unknown Object (File)
	Sat, Dec 7, 2:40 AM

	Unknown Object (File)
	Nov 17 2024, 6:56 AM

	Unknown Object (File)
	Nov 16 2024, 6:21 AM

	Unknown Object (File)
	Nov 12 2024, 2:06 AM

	Unknown Object (File)
	Oct 6 2024, 3:54 AM

	Unknown Object (File)
	Sep 23 2024, 2:08 PM

	Unknown Object (File)
	Sep 2 2024, 10:38 AM

View All 38 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS368571: ipfw kfib algo: Use rt accessors instead of accessing rib/rtentry directly.

Summary

Use rtentry accessors defined in D27416 to avoid direct rtentry field access.
This removes assumptions on prefix storage and rtentry layout from an external code.

Test Plan

2:44 [0] m@devel0 s kldload ipfw
22:44 [0] m@devel0 s ipfw table 10 create algo addr:kfib
22:44 [0] m@devel0 s ipfw table 10 list
0.0.0.0/0 0
10.0.0.0/24 0
10.0.0.157/32 0
127.0.0.1/32 0
::/96 0
::/0 0
::1/128 0
::ffff:0.0.0.0/96 0
2a01:4f8:13a:70c:ffff::/96 0
2a01:4f8:13a:70c:ffff::6/128 0
fe80::/10 0
fe80::/64 0
fe80::5054:ff:fe42:fef/128 0
fe80::/64 0
fe80::1/128 0
ff02::/16 0

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35158
Build 32110: arc lint + arc unit

Event Timeline

melifaro created this revision.Dec 2 2020, 10:40 PM

Herald added subscribers: ae, imp. · View Herald TranscriptDec 2 2020, 10:40 PM

melifaro requested review of this revision.Dec 2 2020, 10:40 PM

Harbormaster completed remote builds in B35158: Diff 80242.Dec 2 2020, 10:40 PM

melifaro edited the summary of this revision. (Show Details)Dec 2 2020, 10:41 PM

melifaro added reviewers: ae, network.

melifaro edited the summary of this revision. (Show Details)Dec 2 2020, 10:45 PM

melifaro edited the test plan for this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2020, 11:57 PM

Closed by commit rS368571: ipfw kfib algo: Use rt accessors instead of accessing rib/rtentry directly. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS368571: ipfw kfib algo: Use rt accessors instead of accessing rib/rtentry directly..

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw_table_algo.c

169 lines

Diff 80242

sys/netpfil/ipfw/ip_fw_table_algo.c

Loading...