Page MenuHomeFreeBSD
Differential D27406

Introduce rib_walk_ext_internal() to allow specifying rib by rnh pointer directly.
ClosedPublic
Actions

Authored by melifaro on Nov 28 2020, 5:23 PM.
Tags
None
Referenced Files
F113049356: D27406.id80118.diff
Tue, Mar 25, 9:34 PM
F113049355: D27406.id80095.diff
Tue, Mar 25, 9:34 PM
F113025637: D27406.diff
Tue, Mar 25, 1:31 PM
Unknown Object (File)
Wed, Mar 19, 10:30 AM
Unknown Object (File)
Wed, Mar 5, 9:52 PM
Unknown Object (File)
Tue, Mar 4, 10:43 AM
Unknown Object (File)
Feb 17 2025, 5:09 AM
Unknown Object (File)
Feb 8 2025, 9:41 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rS368150: Introduce rib_walk_ext_internal() to allow iteration with rnh pointer.
Summary

Introduce rib_walk_ext_internal() to allow specifying rib by rnh pointer directly, instead of fibnum/family.

This solves the case when rib is not yet attached/detached to the system rib map.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35095
Build 32063: arc lint + arc unit

Event Timeline

melifaro created this revision.Nov 28 2020, 5:23 PM
Herald added subscribers: ae, imp. · View Herald TranscriptNov 28 2020, 5:24 PM
Harbormaster completed remote builds in B35095: Diff 80095.Nov 28 2020, 5:24 PM
melifaro requested review of this revision.Nov 28 2020, 5:24 PM
melifaro retitled this revision from Introduce rib_walk_ext_internal() to allow specifying rib by rnh pointer directly, instead of fibnum/family. This solves the case when rib is not yet attached/detached to the system rib map. to Introduce rib_walk_ext_internal() to allow specifying rib by rnh pointer directly..Nov 28 2020, 5:24 PM
melifaro edited the summary of this revision. (Show Details)
melifaro added a reviewer: network.
melifaro added a parent revision: D27401: Add modular routing lookup framework..
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2020, 1:55 PM
Closed by commit rS368150: Introduce rib_walk_ext_internal() to allow iteration with rnh pointer. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rS368150: Introduce rib_walk_ext_internal() to allow iteration with rnh pointer..

Revision Contents
Changeset List

PathSize
sys/
net/
route/
12 lines
16 lines

Diff 80095

View Options

sys/net/route/route_ctl.h

# Created by: Wen Heping <wenheping@gmail.com> # Created by: Wen Heping <wenheping@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= pyliblo PORTNAME= pyliblo
PORTVERSION= 0.10.0 DISTVERSION= 0.10.0
PORTREVISION= 1
CATEGORIES= audio python CATEGORIES= audio python
MASTER_SITES= http://das.nasophon.de/download/ MASTER_SITES= http://das.nasophon.de/download/
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= ports@FreeBSD.org MAINTAINER= ports@FreeBSD.org
COMMENT= Python wrapper for the Liblo OSC Library COMMENT= Python wrapper for the Liblo OSC Library
LICENSE= LGPL21 LICENSE= LGPL21
LICENSE_FILE= ${WRKSRC}/COPYING LICENSE_FILE= ${WRKSRC}/COPYING
BUILD_DEPENDS= pyrex>=0.9.4:devel/pyrex \ BUILD_DEPENDS= cython${PYTHON_VER:M3.*:S/^3/-3/}:lang/cython${PYTHON_MAJOR_VER:M3}
${LOCALBASE}/bin/cython:lang/cython
LIB_DEPENDS= liblo.so:audio/liblo LIB_DEPENDS= liblo.so:audio/liblo
USES= localbase:ldflags python
USES= python USES= python
USE_PYTHON= distutils USE_PYTHON= distutils # autoplist fails to add the manpage files
matUnsubmitted
Not Done
Inline Actions

I don't understand the comment here.

USE_PYTHON=autoplist looks at what files distutils has installed and uses that to generate the plist.

In this port, the man pages are installed manually in post-install, so there is no way that distutils knows about them, so it seems normal that they are not present in the plist generated by autoplist.

mat: I don't understand the comment here. `USE_PYTHON=autoplist` looks at what files `distutils`…
MAKE_ENV+= PREFIX=${PREFIX} LOCALBASE=${LOCALBASE} MAKE_ENV+= PREFIX=${PREFIX} LOCALBASE=${LOCALBASE}
LDFLAGS+= -L${LOCALBASE}/lib
post-patch: post-patch:
${REINPLACE_CMD} -e 's#%%LOCALBASE%%#${LOCALBASE}#g' ${WRKSRC}/setup.py ${REINPLACE_CMD} -e 's#%%LOCALBASE%%#${LOCALBASE}#g' ${WRKSRC}/setup.py
post-install: post-install:
${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/liblo.so ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/liblo.so
${INSTALL_MAN} ${WRKSRC}/scripts/dump_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1 ${INSTALL_MAN} ${WRKSRC}/scripts/dump_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
${INSTALL_MAN} ${WRKSRC}/scripts/send_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1 ${INSTALL_MAN} ${WRKSRC}/scripts/send_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

sys/net/route/route_helpers.c

# Created by: Wen Heping <wenheping@gmail.com> # Created by: Wen Heping <wenheping@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= pyliblo PORTNAME= pyliblo
PORTVERSION= 0.10.0 DISTVERSION= 0.10.0
PORTREVISION= 1
CATEGORIES= audio python CATEGORIES= audio python
MASTER_SITES= http://das.nasophon.de/download/ MASTER_SITES= http://das.nasophon.de/download/
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= ports@FreeBSD.org MAINTAINER= ports@FreeBSD.org
COMMENT= Python wrapper for the Liblo OSC Library COMMENT= Python wrapper for the Liblo OSC Library
LICENSE= LGPL21 LICENSE= LGPL21
LICENSE_FILE= ${WRKSRC}/COPYING LICENSE_FILE= ${WRKSRC}/COPYING
BUILD_DEPENDS= pyrex>=0.9.4:devel/pyrex \ BUILD_DEPENDS= cython${PYTHON_VER:M3.*:S/^3/-3/}:lang/cython${PYTHON_MAJOR_VER:M3}
${LOCALBASE}/bin/cython:lang/cython
LIB_DEPENDS= liblo.so:audio/liblo LIB_DEPENDS= liblo.so:audio/liblo
USES= localbase:ldflags python
USES= python USES= python
USE_PYTHON= distutils USE_PYTHON= distutils # autoplist fails to add the manpage files
matUnsubmitted
Not Done
Inline Actions

I don't understand the comment here.

USE_PYTHON=autoplist looks at what files distutils has installed and uses that to generate the plist.

In this port, the man pages are installed manually in post-install, so there is no way that distutils knows about them, so it seems normal that they are not present in the plist generated by autoplist.

mat: I don't understand the comment here. `USE_PYTHON=autoplist` looks at what files `distutils`…
MAKE_ENV+= PREFIX=${PREFIX} LOCALBASE=${LOCALBASE} MAKE_ENV+= PREFIX=${PREFIX} LOCALBASE=${LOCALBASE}
LDFLAGS+= -L${LOCALBASE}/lib
post-patch: post-patch:
${REINPLACE_CMD} -e 's#%%LOCALBASE%%#${LOCALBASE}#g' ${WRKSRC}/setup.py ${REINPLACE_CMD} -e 's#%%LOCALBASE%%#${LOCALBASE}#g' ${WRKSRC}/setup.py
post-install: post-install:
${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/liblo.so ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/liblo.so
${INSTALL_MAN} ${WRKSRC}/scripts/dump_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1 ${INSTALL_MAN} ${WRKSRC}/scripts/dump_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
${INSTALL_MAN} ${WRKSRC}/scripts/send_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1 ${INSTALL_MAN} ${WRKSRC}/scripts/send_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
.include <bsd.port.mk> .include <bsd.port.mk>