Page MenuHomeFreeBSD
Differential D27330

In g_newprovider_event() return if G_P_WITHER is set
ClosedPublic
Actions

Authored by trasz on Nov 23 2020, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 21, 4:11 AM
Unknown Object (File)
Sun, Sep 20, 9:03 PM
Unknown Object (File)
Sun, Sep 20, 8:37 PM
Unknown Object (File)
Sun, Sep 20, 5:50 PM
Unknown Object (File)
Fri, Sep 11, 2:28 PM
Unknown Object (File)
Sat, Aug 29, 1:59 AM
Unknown Object (File)
Tue, Aug 25, 10:10 AM
Unknown Object (File)
Aug 19 2026, 12:56 PM
View All Files
Subscribers
NetApp

Details

Reviewers
mav
imp
Commits
rG123019739c90: geom(4): make g_newprovider_event() return if G_P_WITHER is set
Summary

In g_newprovider_event() return if G_P_WITHER is set.

This fixes a failed assertion in scenario where the provider
disappears, disk_gone() gets called, and at the exact same
time something else closes the device node triggering a retaste.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34972
Build 31965: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Nov 23 2020, 1:21 PM
trasz created this revision.
Harbormaster completed remote builds in B34972: Diff 79889.Nov 23 2020, 1:21 PM
trasz added a subscriber: NetApp.Nov 23 2020, 1:22 PM
mav accepted this revision.Nov 23 2020, 2:42 PM

Looks good. Few places that call it also check for G_PF_WITHER, but they are using g_post_event() for it, that opens a race window.

This revision is now accepted and ready to land.Nov 23 2020, 2:42 PM
trasz added a comment.Nov 25 2020, 2:14 PM

(Tinderboxed.)

Closed by commit rG123019739c90: geom(4): make g_newprovider_event() return if G_P_WITHER is set (authored by trasz). · Explain WhyDec 29 2020, 2:37 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rG123019739c90: geom(4): make g_newprovider_event() return if G_P_WITHER is set.

Revision Contents
Changeset List

PathSize
sys/
geom/
4 lines

Diff 79889

View Options

sys/geom/geom_subr.c

Loading...