Page MenuHomeFreeBSD

In g_newprovider_event() return if G_P_WITHER is set
ClosedPublic

Authored by trasz on Nov 23 2020, 1:21 PM.
Tags
None
Referenced Files
F132962840: D27330.id81292.diff
Tue, Oct 21, 2:36 PM
Unknown Object (File)
Mon, Oct 20, 5:22 AM
Unknown Object (File)
Mon, Oct 13, 5:04 PM
Unknown Object (File)
Mon, Oct 13, 5:03 PM
Unknown Object (File)
Mon, Oct 13, 5:03 PM
Unknown Object (File)
Mon, Oct 13, 3:50 AM
Unknown Object (File)
Fri, Sep 26, 5:18 PM
Unknown Object (File)
Tue, Sep 23, 10:56 PM
Subscribers

Details

Summary

In g_newprovider_event() return if G_P_WITHER is set.

This fixes a failed assertion in scenario where the provider
disappears, disk_gone() gets called, and at the exact same
time something else closes the device node triggering a retaste.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34972
Build 31965: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Nov 23 2020, 1:21 PM
trasz created this revision.

Looks good. Few places that call it also check for G_PF_WITHER, but they are using g_post_event() for it, that opens a race window.

This revision is now accepted and ready to land.Nov 23 2020, 2:42 PM