This also eliminates unsafe use of VFS_SYNC(MNT_WAIT).
Requested by: mckusick
Tested by: pho
Paths
| Differential D27269 Authored by kib on Nov 18 2020, 2:43 PM.
Details Summary This also eliminates unsafe use of VFS_SYNC(MNT_WAIT). Requested by: mckusick
Diff Detail
Event TimelineHerald added a subscriber: imp. · View Herald TranscriptNov 18 2020, 2:43 PM2020-11-18 14:43:54 (UTC+0) Harbormaster completed remote builds in B34881: Diff 79703.Nov 18 2020, 2:43 PM2020-11-18 14:43:55 (UTC+0) kib edited the summary of this revision. (Show Details)Nov 18 2020, 2:44 PM2020-11-18 14:44:27 (UTC+0) Comment Actions Fix bug in unmount, do not resume writes when we did not suspended them, on error. Harbormaster completed remote builds in B34902: Diff 79749.Nov 19 2020, 12:25 PM2020-11-19 12:25:21 (UTC+0) kib edited the summary of this revision. (Show Details)Nov 19 2020, 12:25 PM2020-11-19 12:25:35 (UTC+0) Comment Actions Thanks for doing this cleanup. This looks good to me, though I had a question on one detail.
kib added inline comments.
This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2020, 12:31 PM2020-11-20 12:31:19 (UTC+0) Closed by commit rS367890: msdosfs: Add trivial support for suspension. (authored by kib). · Explain Why This revision was automatically updated to reflect the committed changes. kib marked an inline comment as done. Harbormaster completed remote builds in B34927: Diff 79798.Nov 20 2020, 12:37 PM2020-11-20 12:37:55 (UTC+0) This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2020, 3:19 PM2020-11-20 15:19:44 (UTC+0) Closed by commit rS367895: msdosfs: suspend around unmount or remount rw->ro. (authored by kib). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions Belatedly, these changes look good and in particular get rid of VOP_SYNC(..., MNT_WAIT).
Revision Contents
Diff 79801 head/sys/fs/msdosfs/msdosfs_vfsops.c
|