[malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4
ClosedPublic
Actions

Authored by adrian on Nov 11 2020, 10:45 PM.

Details

Reviewers

Commits

rS367629: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4

Summary

This sets off gcc-6.4 to spit out a 'error: missing braces around initializer'
error when compiling this. Adding a second set of braces around the 0
sub-struct initializer fixes things.

Test Plan

compiled for gcc-6.4

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34772
Build 31822: arc lint + arc unit

Event Timeline

adrian created this revision.Nov 11 2020, 10:45 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 11 2020, 10:45 PM

adrian requested review of this revision.Nov 11 2020, 10:45 PM

Harbormaster completed remote builds in B34749: Diff 79446.Nov 11 2020, 10:45 PM

brooks added a subscriber: brooks.Nov 11 2020, 10:46 PM

brooks added inline comments.

sys/sys/malloc.h
149–150	Just drop the initialization. Designated initializers zero all members not mentioned.

update based on comment from brooks@

Harbormaster completed remote builds in B34772: Diff 79488.Nov 12 2020, 10:48 PM

brooks accepted this revision.Nov 13 2020, 12:45 AM

This revision is now accepted and ready to land.Nov 13 2020, 12:45 AM

Closed by commit rS367629: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4 (authored by adrian). · Explain WhyNov 13 2020, 1:54 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rS367629: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.

Revision Contents
Changeset List

Path

Size

sys/

malloc.h

1 line

Diff 79488

View Options

[malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4ClosedPublicActions