In binutils opcodes avoid left shifting negative values
ClosedPublic
Actions

Authored by dan.mcgregor_usask.ca on Aug 13 2015, 9:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 16, 9:03 AM

	Unknown Object (File)
	Sat, Aug 16, 9:03 AM

	Unknown Object (File)
	Sat, Aug 16, 9:03 AM

	Unknown Object (File)
	Sat, Aug 16, 8:50 AM

	Unknown Object (File)
	Fri, Aug 15, 5:29 AM

	Unknown Object (File)
	Fri, Aug 15, 12:35 AM

	Unknown Object (File)
	Sun, Aug 3, 7:21 PM

	Unknown Object (File)
	Mon, Jul 28, 10:57 AM

View All Files

Subscribers

andrew

imp

Details

Reviewers

dim

Commits

rS289078: MFC r288099:
rS288099: In binutils' arm-dis.c, avoid left-shifting a negative number.

Summary

In binutils, avoid undefined behaviour in arm opcodes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dan.mcgregor_usask.ca updated this revision to Diff 7934.Aug 13 2015, 9:09 PM

dan.mcgregor_usask.ca retitled this revision from to In binutils opcodes avoid left shifting negative values.

dan.mcgregor_usask.ca updated this object.

dan.mcgregor_usask.ca edited the test plan for this revision. (Show Details)

dan.mcgregor_usask.ca added a reviewer: dim.

dan.mcgregor_usask.ca set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: andrew, imp. · View Herald TranscriptAug 13 2015, 9:09 PM

LGTM.

This revision is now accepted and ready to land.Aug 13 2015, 9:22 PM

Closed by commit rS288099: In binutils' arm-dis.c, avoid left-shifting a negative number. (authored by dim). · Explain WhySep 22 2015, 9:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

contrib/

binutils/

opcodes/

arm-dis.c

2 lines

Diff 7934

View Options

contrib/binutils/opcodes/arm-dis.c

In binutils opcodes avoid left shifting negative valuesClosedPublicActions