Page MenuHomeFreeBSD
Differential D27076

amd64: Make it easier to configure exception stack sizes
ClosedPublic
Actions

Authored by markj on Nov 3 2020, 3:09 PM.
Tags
None
Referenced Files
F154055435: D27076.id79133.diff
Sat, Apr 25, 7:32 PM
Unknown Object (File)
Sun, Apr 19, 12:48 PM
Unknown Object (File)
Sun, Apr 19, 3:45 AM
Unknown Object (File)
Sat, Apr 18, 10:21 PM
Unknown Object (File)
Sat, Apr 18, 7:28 PM
Unknown Object (File)
Thu, Apr 16, 9:32 PM
Unknown Object (File)
Sun, Apr 12, 12:44 AM
Unknown Object (File)
Thu, Apr 9, 3:14 AM
View All Files
Subscribers
imp
NetApp

Details

Reviewers
kib
Commits
rS367335: amd64: Make it easier to configure exception stack sizes
Summary

We handle certain types of exceptions on a dedicated per-CPU stack.
Currently the sizes of these stacks are all hard-coded to PAGE_SIZE, but
for at least NMI handling it can be useful to configure larger stacks.
Add constants to intr_machdep.h to make this easier to tweak, since
exception stacks are allocated both in .bss and during AP startup.

No functional change intended.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34601
Build 31690: arc lint + arc unit

Event Timeline

markj requested review of this revision.Nov 3 2020, 3:09 PM
markj created this revision.
Harbormaster completed remote builds in B34599: Diff 79131.Nov 3 2020, 3:09 PM
markj added a reviewer: kib.Nov 3 2020, 3:09 PM
markj added a subscriber: NetApp.
kib added a comment.Nov 3 2020, 3:44 PM

You need to adjust pmap_pti_init() as well.

markj updated this revision to Diff 79133.Nov 3 2020, 4:29 PM

Make sure PTI uses the correct stack sizes.

Harbormaster completed remote builds in B34601: Diff 79133.Nov 3 2020, 4:29 PM
kib accepted this revision.Nov 3 2020, 5:35 PM
This revision is now accepted and ready to land.Nov 3 2020, 5:35 PM
Closed by commit rS367335: amd64: Make it easier to configure exception stack sizes (authored by markj). · Explain WhyNov 4 2020, 4:42 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS367335: amd64: Make it easier to configure exception stack sizes.
Herald added a subscriber: imp. · View Herald TranscriptNov 4 2020, 4:42 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
8 lines
19 lines
9 lines
include/
5 lines

Diff 79133

View Options

sys/amd64/amd64/machdep.c

Loading...
View Options

sys/amd64/amd64/mp_machdep.c

Loading...
View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/amd64/include/intr_machdep.h

Loading...