ifconfig: properly detect invalid mediaopt keywords.
ClosedPublic
Actions

Authored by kib on Nov 2 2020, 6:54 PM.

Details

Reviewers

• hselasky
kp

Commits

rS367285: ifconfig: properly detect invalid mediaopt keywords.

Summary

When invalid keyword is specified, ifconfig(8) is silent about it, instead random request is sent to the driver.
Before the patch:

root@r-freeb43:~ # ifconfig mce0 mediaopt -txpause,-rxpause
ifconfig: SIOCSIFMEDIA (media): Device not configured

After:

root@r-freeb43:~ # ifconfig mce0 mediaopt -txpause,-rxpause
ifconfig: unknown option: -txpause

Sponsored by: Mellanox Technologies / NVidia Networking

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Nov 2 2020, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 2 2020, 6:54 PM

kib requested review of this revision.Nov 2 2020, 6:54 PM

Harbormaster completed remote builds in B34573: Diff 79085.Nov 2 2020, 6:55 PM

kib edited the summary of this revision. (Show Details)Nov 2 2020, 6:55 PM

kib edited the summary of this revision. (Show Details)Nov 2 2020, 6:58 PM

• hselasky accepted this revision.Nov 2 2020, 7:07 PM

This revision is now accepted and ready to land.Nov 2 2020, 7:07 PM

kp accepted this revision.Nov 2 2020, 9:11 PM

Closed by commit rS367285: ifconfig: properly detect invalid mediaopt keywords. (authored by kib). · Explain WhyNov 2 2020, 9:47 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS367285: ifconfig: properly detect invalid mediaopt keywords..

Revision Contents
Changeset List

Path

Size

head/

sbin/

ifconfig/

ifmedia.c

5 lines

Diff 79107

View Options

head/sbin/ifconfig/ifmedia.c

ifconfig: properly detect invalid mediaopt keywords.ClosedPublicActions