Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
F148934039: D26985.diff
Sat, Mar 21, 3:28 AM
F148804369: D26985.id78848.diff
Fri, Mar 20, 7:27 AM
Unknown Object (File)
Thu, Mar 19, 11:37 PM
Unknown Object (File)
Thu, Mar 19, 11:37 PM
Unknown Object (File)
Sun, Mar 8, 8:49 PM
Unknown Object (File)
Dec 25 2025, 11:50 AM
Unknown Object (File)
Dec 2 2025, 5:24 AM
Unknown Object (File)
Nov 27 2025, 10:06 AM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable