Page MenuHomeFreeBSD

linux(4): Quiesce warning about madvise(..., -1)
ClosedPublic

Authored by cem on Oct 30 2020, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Tue, Oct 21, 7:44 PM
Unknown Object (File)
Mon, Oct 20, 5:14 AM
Unknown Object (File)
Sat, Oct 18, 5:01 PM
Unknown Object (File)
Sat, Oct 18, 8:38 AM
Subscribers

Details

Summary

This API misuse is intended to produce an error value to detect certain
bogus stub implementations of MADV_WIPEONFORK. We don't need to log a
warning about it.

Test Plan

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34505
Build 31603: arc lint + arc unit

Event Timeline

cem requested review of this revision.Oct 30 2020, 12:04 AM
cem created this revision.
emaste added inline comments.
sys/compat/linux/linux_mmap.c
409

Change is fine although this feels odd to me, seems clearer to just have the -1 special case with a return EINVAL leaving the default as it is.

414
This revision is now accepted and ready to land.Oct 30 2020, 1:46 AM

Ah I didn't see the URL above :)

sys/compat/linux/linux_mmap.c
409

Sure, if that seems clearer I have no objection to structuring it separately.

cem marked an inline comment as done.

Separate -1 and default cases.

This revision now requires review to proceed.Oct 30 2020, 5:31 PM
This revision is now accepted and ready to land.Oct 30 2020, 5:40 PM
This revision was automatically updated to reflect the committed changes.