Page MenuHomeFreeBSD
Differential D27017

linux(4): Quiesce warning about madvise(..., -1)
ClosedPublic
Actions

Authored by cem on Oct 30 2020, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Wed, Oct 22, 8:03 AM
Unknown Object (File)
Tue, Oct 21, 7:44 PM
Unknown Object (File)
Mon, Oct 20, 5:14 AM
Unknown Object (File)
Sat, Oct 18, 5:01 PM
Unknown Object (File)
Sat, Oct 18, 8:38 AM
View All 83 Files
Subscribers
imp

Details

Reviewers
trasz
emaste
Commits
rS367182: linux(4): Quiesce warning about madvise(..., -1)
Summary

This API misuse is intended to produce an error value to detect certain
bogus stub implementations of MADV_WIPEONFORK. We don't need to log a
warning about it.

Test Plan

https://boringssl.googlesource.com/boringssl/+/ad5582985cc6b89d0e7caf0d9cc7e301de61cf66%5E%21/

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34505
Build 31603: arc lint + arc unit

Event Timeline

cem requested review of this revision.Oct 30 2020, 12:04 AM
cem created this revision.
Harbormaster completed remote builds in B34491: Diff 78938.Oct 30 2020, 12:04 AM
cem edited the test plan for this revision. (Show Details)Oct 30 2020, 12:12 AM
emaste accepted this revision.Oct 30 2020, 1:46 AM
emaste added inline comments.
sys/compat/linux/linux_mmap.c
409

Change is fine although this feels odd to me, seems clearer to just have the -1 special case with a return EINVAL leaving the default as it is.

414

I didn't find it in OpenSSL. BoringSSL is here: https://boringssl.googlesource.com/boringssl/+/ad5582985cc6b89d0e7caf0d9cc7e301de61cf66

This revision is now accepted and ready to land.Oct 30 2020, 1:46 AM
emaste added a comment.Oct 30 2020, 1:47 AM

Ah I didn't see the URL above :)

cem added inline comments.Oct 30 2020, 2:09 AM
sys/compat/linux/linux_mmap.c
409

Sure, if that seems clearer I have no objection to structuring it separately.

cem updated this revision to Diff 78962.Oct 30 2020, 5:31 PM
cem marked an inline comment as done.

Separate -1 and default cases.

This revision now requires review to proceed.Oct 30 2020, 5:31 PM
Harbormaster completed remote builds in B34505: Diff 78962.Oct 30 2020, 5:31 PM
trasz accepted this revision.Oct 30 2020, 5:40 PM
This revision is now accepted and ready to land.Oct 30 2020, 5:40 PM
emaste accepted this revision.Oct 30 2020, 5:56 PM
Closed by commit rS367182: linux(4): Quiesce warning about madvise(..., -1) (authored by cem). · Explain WhyOct 30 2020, 7:03 PM
This revision was automatically updated to reflect the committed changes.
cem added a commit: rS367182: linux(4): Quiesce warning about madvise(..., -1).
Herald added a subscriber: imp. · View Herald TranscriptOct 30 2020, 7:03 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
10 lines

Diff 78962

View Options

sys/compat/linux/linux_mmap.c

Loading...