arm64: set the correct partition type in make-memstick.sh
ClosedPublic
Actions

Authored by mhorne on Oct 28 2020, 2:22 PM.

Details

Reviewers

emaste

Commits

rS367178: arm64: set the correct partition type in make-memstick.sh

Summary

We create a UFS root filesystem using makefs(8), and later pass it to mkimg(1) when
creating the final image. The correct partition type is freebsd-ufs; the freebsd
parition type is for partitions containing a BSD disklabel.

Test Plan

With this change:

# gpart show
=>     3  672344  vtbd0  GPT  (328M)
       3   66584      1  efi  (33M)
   66587  605760      2  freebsd-ufs  (296M)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34438
Build 31542: arc lint + arc unit

Event Timeline

mhorne created this revision.Oct 28 2020, 2:22 PM

Herald added a subscriber: andrew. · View Herald TranscriptOct 28 2020, 2:22 PM

Harbormaster completed remote builds in B34438: Diff 78852.Oct 28 2020, 2:22 PM

mhorne requested review of this revision.Oct 28 2020, 2:22 PM

This is just the partition type reported in the gpt header is it not?
i.e. there was not actually a disklabel before

In D26987#602005, @emaste wrote:

This is just the partition type reported in the gpt header is it not?
i.e. there was not actually a disklabel before

Ahh, this highlights the gap in my understanding. I was unsure if -p freebsd:= actually created the disklabel or not, but upon another reading it clearly just sets the partition type, with whatever contents you pass to it.

So yes, that is what this change actually does. I will reword the description.

mhorne retitled this revision from Don't use BSD disklabels in arm64 make-memstick.sh to arm64: set the correct partition type in make-memstick.sh.Oct 28 2020, 4:30 PM

mhorne edited the summary of this revision. (Show Details)

emaste accepted this revision.Oct 28 2020, 5:03 PM

This revision is now accepted and ready to land.Oct 28 2020, 5:03 PM

Closed by commit rS367178: arm64: set the correct partition type in make-memstick.sh (authored by mhorne). · Explain WhyOct 30 2020, 6:22 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS367178: arm64: set the correct partition type in make-memstick.sh.

Herald added a subscriber: imp. · View Herald TranscriptOct 30 2020, 6:22 PM