Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
F175487324: D26985.id78848.diff
Sun, Oct 11, 5:16 AM
Unknown Object (File)
Sun, Oct 11, 2:09 AM
Unknown Object (File)
Fri, Oct 9, 11:19 PM
Unknown Object (File)
Fri, Oct 9, 4:05 PM
Unknown Object (File)
Fri, Oct 9, 3:34 PM
Unknown Object (File)
Fri, Oct 2, 1:44 PM
Unknown Object (File)
Sun, Sep 27, 5:21 PM
Unknown Object (File)
Tue, Sep 22, 9:26 AM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34435
Build 31539: arc lint + arc unit