ubuf is too small to hold a human readable 64 bit value
ClosedPublic
Actions

Authored by bret_ketchum_dell.com on Oct 21 2020, 4:57 PM.

Tags

None

Referenced Files

	F108521812: D26893.diff
	Sat, Jan 25, 9:03 PM

	Unknown Object (File)
	Fri, Jan 17, 7:27 PM

	Unknown Object (File)
	Tue, Jan 14, 10:37 AM

	Unknown Object (File)
	Tue, Jan 14, 10:37 AM

	Unknown Object (File)
	Tue, Jan 14, 10:37 AM

	Unknown Object (File)
	Tue, Jan 14, 9:49 AM

	Unknown Object (File)
	Mon, Jan 13, 11:44 PM

	Unknown Object (File)
	Sat, Jan 11, 10:43 AM

View All 57 Files

Subscribers

imp

Details

Reviewers

markj
mav
vangyzen

Commits

rS366914: ntb_tool: ubuf is too small to hold a human readable 64 bit value

Summary

ubuf buffer is too small. It should be 18 if a NULL is not needed, or 19 to hold the NULL terminator for the full 64-BIT value plus the 0x prefix.

Test Plan

Run ntb_tool.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bret_ketchum_dell.com requested review of this revision.Oct 21 2020, 4:57 PM

bret_ketchum_dell.com created this revision.

markj accepted this revision.Oct 21 2020, 5:00 PM

This revision is now accepted and ready to land.Oct 21 2020, 5:00 PM

mav accepted this revision.Oct 21 2020, 5:06 PM

vangyzen accepted this revision.Oct 21 2020, 5:07 PM

Closed by commit rS366914: ntb_tool: ubuf is too small to hold a human readable 64 bit value (authored by vangyzen). · Explain WhyOct 21 2020, 5:12 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rS366914: ntb_tool: ubuf is too small to hold a human readable 64 bit value.

Herald added a subscriber: imp. · View Herald TranscriptOct 21 2020, 5:12 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ntb/

test/

ntb_tool.c

2 lines

Diff 78558

View Options

head/sys/dev/ntb/test/ntb_tool.c

ubuf is too small to hold a human readable 64 bit valueClosedPublicActions