Fix a couple of bugs for asym crypto introduced in r359374.
ClosedPublic
Actions

Authored by jhb on Oct 15 2020, 10:03 PM.

Details

Reviewers

markj
jmg

Commits

rS366852: Fix a couple of bugs for asym crypto introduced in r359374.

Summary

Check for null pointers in the crypto_drivers[] array when checking for empty slots in crypto_select_kdriver().

Handle the case where crypto_kdone() is invoked on a request where krq_cap is NULL due to not finding a matching driver.

Test Plan

run src/tools/tools/cryptokeytest, it panicked until these were fixed

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 34203
Build 31353: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Oct 15 2020, 10:03 PM

jhb created this revision.

Harbormaster completed remote builds in B34203: Diff 78291.Oct 15 2020, 10:03 PM

markj accepted this revision.Oct 16 2020, 1:44 PM

markj added inline comments.

sys/opencrypto/crypto.c
1543	This can be one line.

This revision is now accepted and ready to land.Oct 16 2020, 1:44 PM

jhb added inline comments.Oct 19 2020, 8:00 PM

sys/opencrypto/crypto.c
1543	Yes, it is still split out as two lines in the similar function for symmetric drivers which is why I left it this way. I might do a followup to fix both functions though.

Closed by commit rS366852: Fix a couple of bugs for asym crypto introduced in r359374. (authored by jhb). · Explain WhyOct 19 2020, 8:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366852: Fix a couple of bugs for asym crypto introduced in r359374..

Herald added a reviewer: jmg. · View Herald TranscriptOct 19 2020, 8:04 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

crypto.c

21 lines

Diff 78291

View Options

Fix a couple of bugs for asym crypto introduced in r359374.ClosedPublicActions