physio: Don't store user addresses in bio_data
ClosedPublic
Actions

Authored by brooks on Oct 14 2020, 10:01 PM.

Details

Reviewers

jhb
imp
markj

Commits

rS366939: MFC r366731:
rS366938: MFC r366731:
rS366731: physio: Don't store user addresses in bio_data

Summary

Only assign the address from the iovec to bio_data if it is a kernel
address. This is the single place where bio_data stored (however briefly)
a userspace pointer.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks requested review of this revision.Oct 14 2020, 10:01 PM

brooks created this revision.

Harbormaster completed remote builds in B34171: Diff 78235.Oct 14 2020, 10:01 PM

Cirrus-CI run https://cirrus-ci.com/task/5195860164214784

I needed this change in CheriBSD because we can't store user pointers in bio_data due to a type mismatch and we need to pass the pointer (rather than an address) to vm_fault_quick_hold_pages.

markj accepted this revision.Oct 14 2020, 11:37 PM

This revision is now accepted and ready to land.Oct 14 2020, 11:37 PM

imp accepted this revision.Oct 14 2020, 11:39 PM

Closed by commit rS366731: physio: Don't store user addresses in bio_data (authored by brooks). · Explain WhyOct 15 2020, 5:05 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS366731: physio: Don't store user addresses in bio_data.

brooks added a commit: rS366938: MFC r366731:.Oct 22 2020, 4:27 PM

brooks added a commit: rS366939: MFC r366731:.Oct 22 2020, 4:29 PM