Page MenuHomeFreeBSD

Remove UNIQUENAME.
ClosedPublic

Authored by mat on Aug 7 2015, 9:26 PM.
Referenced Files
F80195227: D3336.id7769.diff
Fri, Mar 29, 2:30 AM
F80151040: D3336.id7773.diff
Thu, Mar 28, 2:37 PM
Unknown Object (File)
Wed, Mar 27, 4:47 AM
Unknown Object (File)
Sat, Mar 2, 1:23 AM
Unknown Object (File)
Feb 22 2024, 7:04 PM
Unknown Object (File)
Feb 19 2024, 4:29 AM
Unknown Object (File)
Feb 13 2024, 10:52 PM
Unknown Object (File)
Feb 3 2024, 9:14 PM
Subscribers

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37
Build 37: arc lint + arc unit

Event Timeline

mat retitled this revision from to Remove UNIQUENAME..
mat updated this object.
mat edited the test plan for this revision. (Show Details)

Please add a UNIQUENAME check in bsd.sanity.mk !

mat edited edge metadata.
  • Remove NO_LATEST_LINK, it's a no-op.
  • Use PKGBASE instead of LATEST_LINK in PKGLATESTFILE, the *only* consumer
  • Remove obsolete documentation.
  • Remove LATEST_LINK.
  • Add UNIQUENAME and LATEST_LINK to the sanity checks.
  • Fix logic.
  • Remove UNIQUENAME.
mat edited projects, added portmgr; removed pkg.
mat removed reviewers: bapt, bdrewery.

Maybe remove OPTIONSFILE code from Mk/bsd.port.mk and Makefiles too?

  • Now that UNIQUENAME is gone, OPTIONSFILE is too.
mat edited edge metadata.

Rebase.

mat edited edge metadata.
  • Add a note about UNIQUENAME and LATEST_LINK removal.
bapt edited edge metadata.

LGTM

needs an exp-run :-)

I think I'm through with the patch, feel free to run one :-)

There are 1 new failure and 2 new QA errors:

+ {"origin"=>"devel/php-memoize", "pkgname"=>"php-memoize-0.2.0b1_2", "phase"=>"fetch", "errortype"=>"distinfo_update"}
+ {"origin"=>"emulators/i386-wine-devel", "pkgname"=>"i386-wine-devel-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}
+ {"origin"=>"emulators/i386-wine-staging", "pkgname"=>"i386-wine-staging-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}

Error logs:

http://package22.nyi.freebsd.org/data/93i386-default-D3336/2015-08-13_09h42m29s/logs/errors/php-memoize-0.2.0b1_2.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-staging-1.7.48,1.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-devel-1.7.48,1.log

There are 1 new failure and 2 new QA errors:

+ {"origin"=>"devel/php-memoize", "pkgname"=>"php-memoize-0.2.0b1_2", "phase"=>"fetch", "errortype"=>"distinfo_update"}
+ {"origin"=>"emulators/i386-wine-devel", "pkgname"=>"i386-wine-devel-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}
+ {"origin"=>"emulators/i386-wine-staging", "pkgname"=>"i386-wine-staging-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}

Error logs:

http://package22.nyi.freebsd.org/data/93i386-default-D3336/2015-08-13_09h42m29s/logs/errors/php-memoize-0.2.0b1_2.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-staging-1.7.48,1.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-devel-1.7.48,1.log

Ok, fixed all those.

mat edited edge metadata.
  • fix php-memoize sillyness.
  • Fix i386-wine-{devel,staging}
mat edited edge metadata.
  • Add warnings about options set with UNIQUENAME.
mat edited edge metadata.
  • Add a bit in UPDATING too.
This revision was automatically updated to reflect the committed changes.