- universe built all kernels ok on amd64, i386, and pc98.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 27 Build 27: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for doing all this! I will try to test the patch this afternoon. I'm also going to be on vacation next week (without Internet or laptop).
| sys/dev/xen/netfront/netfront.c | ||
|---|---|---|
| 1002 | This chunk is wrong and should be removed. I guess the extra "!" in the if condition was a mistake. The __HYPERVISOR_mmu_update hypercall is not available for auto-translated guests. | |
| sys/xen/gnttab.h | ||
| 127 | GNTMAP_contains_pte is not available for auto-translated guests, in fact we should add a check like: if (flags & (GNTMAP_device_map|GNTMAP_application_map|GNTMAP_contains_pte) != 0)
panic("Invalid grant table flags specified");But that can be done later. | |
Comment Actions
Building HEAD is currently broken, and I have to leave ASAP, so I won't be able to test it until the 15th (a week from now). Feel free to commit it.
Comment Actions
Ok, I'll do the gnttab thing as a followup to this one.
| sys/dev/xen/netfront/netfront.c | ||
|---|---|---|
| 995–996 | I wonder if the !! in the old code was actually a bug and if this code is supposed to only be present for the !auto case? If so then I can remove some more bits such as the rx_mcl and rx_mmu arrays from the softc. | |