Page MenuHomeFreeBSD
Differential D25260

ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO
ClosedPublic
Actions

Authored by val_packett.cool on Jun 13 2020, 5:24 PM.
Tags
None
Referenced Files
F114914509: D25260.id77738.diff
Fri, Apr 18, 11:54 AM
Unknown Object (File)
Tue, Apr 15, 6:40 AM
Unknown Object (File)
Tue, Apr 15, 4:55 AM
Unknown Object (File)
Sun, Apr 6, 9:39 AM
Unknown Object (File)
Tue, Mar 25, 12:02 AM
Unknown Object (File)
Sun, Mar 23, 7:34 AM
Unknown Object (File)
Jan 28 2025, 11:22 PM
Unknown Object (File)
Jan 24 2025, 7:24 PM
View All 42 Files
Subscribers
imp

Details

Reviewers
mav
gavin
imp
manu
Group Reviewers
Contributor Reviews (src)
Commits
rS366330: ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO
Summary

devmatch all the things

Test Plan

auto attaches fine on kabylake

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

val_packett.cool requested review of this revision.Jun 13 2020, 5:24 PM
val_packett.cool created this revision.
Harbormaster completed remote builds in B31687: Diff 73077.Jun 13 2020, 5:24 PM
val_packett.cool added reviewers: Contributor Reviews (src), mav, gavin.Jun 13 2020, 5:27 PM
val_packett.cool set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 13 2020, 5:27 PM
mav accepted this revision.Jun 13 2020, 5:31 PM

Makes sense to me, but I am not very familiar with the PNP_INFO code.

This revision is now accepted and ready to land.Jun 13 2020, 5:31 PM
mav added a reviewer: imp.Jun 13 2020, 5:33 PM
val_packett.cool added a comment.Aug 22 2020, 9:11 AM

ping.. can anyone commit?

val_packett.cool added a reviewer: manu.Oct 1 2020, 3:58 PM
manu accepted this revision.Oct 1 2020, 4:10 PM

LGTM
Will commit later today.
Thanks.

Closed by commit rS366330: ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO (authored by manu). · Explain WhyOct 1 2020, 4:55 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rS366330: ichsmb_pci: convert to pci_device_table / add PCI_PNP_INFO.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ichsmb/
142 lines

Diff 77738

View Options

head/sys/dev/ichsmb/ichsmb_pci.c

Show All 26 Lines
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include "gve.h" #include "gve.h"
#include "gve_adminq.h" #include "gve_adminq.h"
#include "gve_dqo.h" #include "gve_dqo.h"
#define GVE_DRIVER_VERSION "GVE-FBSD-1.3.2\n" #define GVE_DRIVER_VERSION "GVE-FBSD-1.3.3\n"
#define GVE_VERSION_MAJOR 1 #define GVE_VERSION_MAJOR 1
#define GVE_VERSION_MINOR 3 #define GVE_VERSION_MINOR 3
#define GVE_VERSION_SUB 2 #define GVE_VERSION_SUB 3
#define GVE_DEFAULT_RX_COPYBREAK 256 #define GVE_DEFAULT_RX_COPYBREAK 256
/* Devices supported by this driver. */ /* Devices supported by this driver. */
static struct gve_dev { static struct gve_dev {
uint16_t vendor_id; uint16_t vendor_id;
uint16_t device_id; uint16_t device_id;
const char *name; const char *name;
▲ Show 20 Lines • Show All 206 Lines • ▼ Show 20 Linesgve_adjust_tx_queues(struct gve_priv *priv, uint16_t new_queue_cnt)
} }
priv->tx_cfg.num_queues = new_queue_cnt; priv->tx_cfg.num_queues = new_queue_cnt;
err = gve_up(priv); err = gve_up(priv);
if (err != 0) if (err != 0)
gve_schedule_reset(priv); gve_schedule_reset(priv);
return (err); return (err);
}
int
gve_adjust_ring_sizes(struct gve_priv *priv, uint16_t new_desc_cnt, bool is_rx)
{
int err;
uint16_t prev_desc_cnt;
GVE_IFACE_LOCK_ASSERT(priv->gve_iface_lock);
gve_down(priv);
if (is_rx) {
gve_free_rx_rings(priv, 0, priv->rx_cfg.num_queues);
prev_desc_cnt = priv->rx_desc_cnt;
priv->rx_desc_cnt = new_desc_cnt;
err = gve_alloc_rx_rings(priv, 0, priv->rx_cfg.num_queues);
if (err != 0) {
device_printf(priv->dev,
"Failed to allocate rings. Trying to start back up with previous ring size.");
priv->rx_desc_cnt = prev_desc_cnt;
err = gve_alloc_rx_rings(priv, 0, priv->rx_cfg.num_queues);
}
} else {
gve_free_tx_rings(priv, 0, priv->tx_cfg.num_queues);
prev_desc_cnt = priv->tx_desc_cnt;
priv->tx_desc_cnt = new_desc_cnt;
err = gve_alloc_tx_rings(priv, 0, priv->tx_cfg.num_queues);
if (err != 0) {
device_printf(priv->dev,
"Failed to allocate rings. Trying to start back up with previous ring size.");
priv->tx_desc_cnt = prev_desc_cnt;
err = gve_alloc_tx_rings(priv, 0, priv->tx_cfg.num_queues);
}
}
if (err != 0) {
device_printf(priv->dev, "Failed to allocate rings! Cannot start device back up!");
gve_down(priv);
markjUnsubmitted
Done
Inline Actions

Is this gve_down() call needed, given that we already bought the interface down?

markj: Is this gve_down() call needed, given that we already bought the interface down?
return (err);
}
err = gve_up(priv);
if (err != 0) {
gve_schedule_reset(priv);
return (err);
}
return (0);
} }
static int static int
gve_set_mtu(if_t ifp, uint32_t new_mtu) gve_set_mtu(if_t ifp, uint32_t new_mtu)
{ {
struct gve_priv *priv = if_getsoftc(ifp); struct gve_priv *priv = if_getsoftc(ifp);
const uint32_t max_problem_range = 8227; const uint32_t max_problem_range = 8227;
const uint32_t min_problem_range = 7822; const uint32_t min_problem_range = 7822;
▲ Show 20 Lines • Show All 755 Lines • Show Last 20 Lines