Page MenuHomeFreeBSD
Differential D3336

Remove UNIQUENAME.
ClosedPublic
Actions

Authored by mat on Aug 7 2015, 9:26 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Oct 5, 11:40 PM
Unknown Object (File)
Sat, Oct 4, 9:19 AM
Unknown Object (File)
Sat, Oct 4, 1:07 AM
Unknown Object (File)
Thu, Oct 2, 11:46 PM
Unknown Object (File)
Thu, Oct 2, 10:05 AM
Unknown Object (File)
Wed, Oct 1, 9:20 PM
Unknown Object (File)
Wed, Oct 1, 6:28 PM
Unknown Object (File)
Wed, Oct 1, 4:28 AM
View All Files
Subscribers
antoine
bapt

Details

Reviewers
bapt
bdrewery
Group Reviewers
portmgr
Commits
rP394508: Remove UNIQUENAME and LATEST_LINK.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21
Build 21: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 7769.Aug 7 2015, 9:26 PM
mat retitled this revision from to Remove UNIQUENAME..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptAug 7 2015, 9:26 PM
bapt added a subscriber: bapt.Aug 7 2015, 10:28 PM

Please add a UNIQUENAME check in bsd.sanity.mk !

mat updated this revision to Diff 7773.Aug 8 2015, 9:22 AM
mat edited edge metadata.
  • Remove NO_LATEST_LINK, it's a no-op.
  • Use PKGBASE instead of LATEST_LINK in PKGLATESTFILE, the *only* consumer
  • Remove obsolete documentation.
  • Remove LATEST_LINK.
  • Add UNIQUENAME and LATEST_LINK to the sanity checks.
  • Fix logic.
  • Remove UNIQUENAME.
Herald added reviewers: bapt, bdrewery. · View Herald TranscriptAug 8 2015, 9:22 AM
Herald added a project: pkg. · View Herald Transcript
mat edited edge metadata.Aug 8 2015, 9:24 AM
mat edited projects, added portmgr; removed pkg.
mat removed reviewers: bapt, bdrewery.
antoine added a subscriber: antoine.Aug 8 2015, 10:03 AM

Maybe remove OPTIONSFILE code from Mk/bsd.port.mk and Makefiles too?

mat updated this revision to Diff 7776.Aug 8 2015, 10:29 AM
  • Now that UNIQUENAME is gone, OPTIONSFILE is too.
Herald added reviewers: bapt, bdrewery. · View Herald TranscriptAug 8 2015, 10:29 AM
Herald added a project: pkg. · View Herald Transcript
mat updated this revision to Diff 7801.Aug 9 2015, 12:27 PM
mat edited edge metadata.

Rebase.

Herald edited edge metadata. · View Herald TranscriptAug 9 2015, 12:27 PM
mat updated this revision to Diff 7861.Aug 11 2015, 10:53 AM
mat edited edge metadata.
  • Add a note about UNIQUENAME and LATEST_LINK removal.
Herald edited edge metadata. · View Herald TranscriptAug 11 2015, 10:53 AM
bapt accepted this revision.Aug 11 2015, 12:46 PM
bapt edited edge metadata.

LGTM

antoine added a comment.Aug 11 2015, 1:15 PM

needs an exp-run :-)

mat added a comment.Aug 11 2015, 1:34 PM
In D3336#68311, @antoine wrote:

needs an exp-run :-)

I think I'm through with the patch, feel free to run one :-)

antoine added a comment.Aug 14 2015, 11:17 AM

There are 1 new failure and 2 new QA errors:

+ {"origin"=>"devel/php-memoize", "pkgname"=>"php-memoize-0.2.0b1_2", "phase"=>"fetch", "errortype"=>"distinfo_update"}
+ {"origin"=>"emulators/i386-wine-devel", "pkgname"=>"i386-wine-devel-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}
+ {"origin"=>"emulators/i386-wine-staging", "pkgname"=>"i386-wine-staging-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}

Error logs:

http://package22.nyi.freebsd.org/data/93i386-default-D3336/2015-08-13_09h42m29s/logs/errors/php-memoize-0.2.0b1_2.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-staging-1.7.48,1.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-devel-1.7.48,1.log

mat added a comment.Aug 17 2015, 9:39 AM
In D3336#68899, @antoine wrote:

There are 1 new failure and 2 new QA errors:

+ {"origin"=>"devel/php-memoize", "pkgname"=>"php-memoize-0.2.0b1_2", "phase"=>"fetch", "errortype"=>"distinfo_update"}
+ {"origin"=>"emulators/i386-wine-devel", "pkgname"=>"i386-wine-devel-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}
+ {"origin"=>"emulators/i386-wine-staging", "pkgname"=>"i386-wine-staging-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}

Error logs:

http://package22.nyi.freebsd.org/data/93i386-default-D3336/2015-08-13_09h42m29s/logs/errors/php-memoize-0.2.0b1_2.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-staging-1.7.48,1.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-devel-1.7.48,1.log

Ok, fixed all those.

mat updated this revision to Diff 8002.Aug 17 2015, 9:40 AM
mat edited edge metadata.
  • fix php-memoize sillyness.
  • Fix i386-wine-{devel,staging}
Herald edited edge metadata. · View Herald TranscriptAug 17 2015, 9:40 AM
mat updated this revision to Diff 8003.Aug 17 2015, 9:59 AM
mat edited edge metadata.
  • Add warnings about options set with UNIQUENAME.
Herald edited edge metadata. · View Herald TranscriptAug 17 2015, 9:59 AM
mat updated this revision to Diff 8004.Aug 17 2015, 10:09 AM
mat edited edge metadata.
  • Add a bit in UPDATING too.
Herald edited edge metadata. · View Herald TranscriptAug 17 2015, 10:09 AM
Closed by commit rP394508: Remove UNIQUENAME and LATEST_LINK. (authored by mat). · Explain WhyAug 17 2015, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
14 lines
41 lines
33 lines
5 lines
Tools/
scripts/
2 lines
audio/
amarok-kde4/
2 lines
jack/
2 lines
lua51-mpd/
2 lines
chinese/
joe/
2 lines
phpbb3-tw/
2 lines
databases/
jdbm2/
1 line
luasql-mysql/
1 line
mariadb-client/
2 lines
mariadb-scripts/
1 line
mariadb-server/
2 lines
proftpd-mod_sql_mysql/
1 line
proftpd-mod_sql_odbc/
1 line
proftpd-mod_sql_sqlite/
1 line
proftpd-mod_sql_tds/
1 line
squirrel-sql/
2 lines
deskutils/
gworkspace-gwmetadata/
1 line
devel/
cl-asdf/
6 lines
glib20-reference/
3 lines
insight/
2 lines
llvm-cheri/
1 line
llvm-devel/
1 line
llvm33/
1 line
llvm34/
1 line
llvm35/
1 line
llvm36/
1 line
llvm37/
1 line
ocaml-camlp5/
2 lines
oniguruma/
1 line
oniguruma4/
1 line
php-memoize/
2 lines
py-funcparserlib/
2 lines
subcommander2/
1 line
subversion-static/
1 line
dns/
samba-nsupdate/
10 lines
editors/
2bsd-vi/
2 lines
emacs-nox11/
1 line
libreoffice-i18n/
1 line
openoffice-4/
2 lines
openoffice-devel/
2 lines
emulators/
generator-cbiere/
4 lines
i386-wine-devel/
2 lines
i386-wine/
2 lines
linux_base-c6/
1 line
linux_base-f10/
1 line
virtualbox-ose-additions/
1 line
virtualbox-ose-kmod/
1 line
finance/
ledgersmb12/
2 lines
ftp/
curl-hiphop/
1 line
proftpd-mod_geoip/
1 line
games/
doom-data/
1 line
ioquake3-devel-server/
1 line
ioquake3-server/
1 line
iourbanterror-server/
1 line
linux-quake3/
1 line
nethack33/
1 line
openarena-server/
1 line
opengfx/
1 line
opensfx/
1 line
quake-source/
2 lines
quake2-3zb2/
2 lines
quake2-ctf/
3 lines
quake2-data/
3 lines
quake2-extras/
4 lines
quake2-lights/
2 lines
quake2-matrix/
2 lines
quake2-psychomod/
2 lines
quake2-source/
2 lines
quake2-zaero/
2 lines
tuxpaint-fonts/
3 lines
xpilot-ng-server/
2 lines
graphics/
frei0r-plugins/
3 lines
jgraph/
1 line
libgnomecanvasmm26/
2 lines
py-aafigure/
4 lines
py-actdiag/
2 lines
py-blockdiag/
2 lines
py-imaging/
2 lines
py-nwdiag/
4 lines
py-seqdiag/
4 lines
py-webcolors/
2 lines
quat-gui/
8 lines
java/
netty/
4 lines
openjdk6-jre/
1 line
openjdk7-jre/
2 lines
openjdk7/
2 lines
lang/
fpc-units/
2 lines
gcc46/
1 line
gcc47/
1 line
gcc48/
1 line
gcc49/
1 line
gcc5-devel/
1 line
gcc5/
1 line
gcc6-devel/
1 line
php5/
2 lines
php55/
2 lines
php56/
2 lines
ruby20/
2 lines
ruby21/
1 line
ruby22/
1 line
tcl84/
2 lines
tcl86/
2 lines
mail/
addresses-goodies/
1 line
p5-IMAP-Admin/
2 lines
popa3d/
1 line
qmail-ldap/
1 line
qmail-mysql/
1 line
qmail-spamcontrol/
1 line
qmail-tls/
1 line
wanderlust-devel/
1 line
math/
py-matplotlib/
1 line
py-symeig/
1 line
sage/
2 lines
vtk5/
1 line
vtk6/
2 lines
misc/
gnu-watch/
8 lines
nut/
3 lines
tellico-kde4/
2 lines
multimedia/
gstreamer-qt4/
2 lines
kplayer-kde4/
net-im/
kmess-kde4/
2 lines
py-xmpppy-yahoo/
8 lines
net-mgmt/
netustad/
2 lines
net/
freeradius3/
6 lines
hping-devel/
1 line
isc-dhcp41-server/
2 lines
isc-dhcp42-server/
2 lines
isc-dhcp43-server/
2 lines
mosh/
2 lines
openmpi/
2 lines
proftpd-mod_ldap/
1 line
samba36/
1 line
news/
inn/
2 lines
ports-mgmt/
pkg-devel/
4 lines
pkg/
1 line
print/
cups-base/
3 lines
security/
botan110/
2 lines
gag/
2 lines
krb5-111/
1 line
krb5-112/
1 line
krb5-appl/
1 line
proftpd-mod_clamav/
1 line
py-keyring/
2 lines
shibboleth2-sp/
2 lines
sysutils/
backuppc-devel/
2 lines
bacula-docs/
2 lines
bacula5-docs/
2 lines
boxbackup-devel/
2 lines
cdrtools-devel/
1 line
cfengine32/
1 line
cfengine34/
1 line
cfengine36/
1 line
cfengine37/
1 line
knutclient-kde4/
1 line
pear-Log/
1 line
textproc/
apache-solr/
1 line
flip/
2 lines
ruby-xmlscan/
1 line
sphinxsearch-devel/
2 lines
www/
apache22-event-mpm/
1 line
apache22-itk-mpm/
1 line
apache22-peruser-mpm/
1 line
apache22-worker-mpm/
1 line
autoindex2/
1 line
cocoon/
1 line
dillo2/
1 line
free-sa-devel/
1 line
geronimo/
1 line
linux-opera/
60 lines
mod_auth_kerb2/
1 line
mod_extract_forwarded/
4 lines
mod_layout22/
1 line
mod_macro22/
1 line
mod_myvhost/
1 line
p5-Apache-Clean2/
2 lines
pear-HTTP_FloodControl/
1 line
tdiary/
6 lines
xpi-adblock/
2 lines
x11-toolkits/
tk84/
2 lines
tk85/
4 lines
tk86/
2 lines
x11-wm/
afterstep/
1 line
fvwm/
2 lines
fvwm2/
1 line
xfce4/
1 line
x11/
rsibreak-kde4/
2 lines

Diff 7773

View Options

Mk/bsd.database.mk

Loading...
View Options

Mk/bsd.options.mk

Loading...
View Options

Mk/bsd.port.mk

Loading...
View Options

Mk/bsd.sanity.mk

Loading...
View Options

Tools/scripts/README

Loading...
View Options

Tools/scripts/check-latest-link

Loading...
View Options

audio/amarok-kde4/Makefile

Loading...
View Options

audio/jack/Makefile

Loading...
View Options

audio/lua51-mpd/Makefile

Loading...
View Options

chinese/joe/Makefile

Loading...
View Options

chinese/phpbb3-tw/Makefile

Loading...
View Options

databases/jdbm2/Makefile

Loading...
View Options

databases/luasql-mysql/Makefile

Loading...
View Options

databases/mariadb-client/Makefile

Loading...
View Options

databases/mariadb-scripts/Makefile

Loading...
View Options

databases/mariadb-server/Makefile

Loading...
View Options

databases/proftpd-mod_sql_mysql/Makefile

Loading...
View Options

databases/proftpd-mod_sql_odbc/Makefile

Loading...
View Options

databases/proftpd-mod_sql_sqlite/Makefile

Loading...
View Options

databases/proftpd-mod_sql_tds/Makefile

Loading...
View Options

databases/squirrel-sql/Makefile

Loading...
View Options

deskutils/gworkspace-gwmetadata/Makefile

Loading...
View Options

devel/cl-asdf/bsd.cl-asdf.mk

Loading...
View Options

devel/glib20-reference/bsd.gnome-reference.mk

Loading...
View Options

devel/insight/Makefile

Loading...
View Options

devel/llvm-cheri/Makefile

Loading...
View Options

devel/llvm-devel/Makefile

Loading...
View Options

devel/llvm33/Makefile

Loading...
View Options

devel/llvm34/Makefile

Loading...
View Options

devel/llvm35/Makefile

Loading...
View Options

devel/llvm36/Makefile

Loading...
View Options

devel/llvm37/Makefile

Loading...
View Options

devel/ocaml-camlp5/Makefile

Loading...
View Options

devel/oniguruma/Makefile

Loading...
View Options

devel/oniguruma4/Makefile

Loading...
View Options

devel/php-memoize/Makefile

Loading...
View Options

devel/py-funcparserlib/Makefile

Loading...
View Options

devel/subcommander2/Makefile

Loading...
View Options

devel/subversion-static/Makefile

Loading...
View Options

dns/samba-nsupdate/Makefile

Loading...
View Options

editors/2bsd-vi/Makefile

Loading...
View Options

editors/emacs-nox11/Makefile

Loading...
View Options

editors/libreoffice-i18n/Makefile

Loading...
View Options

editors/openoffice-4/Makefile

Loading...
View Options

editors/openoffice-devel/Makefile

Loading...
View Options

emulators/generator-cbiere/Makefile

Loading...
View Options

emulators/i386-wine-devel/Makefile.inc

Loading...
View Options

emulators/i386-wine/Makefile.inc

Loading...
View Options

emulators/linux_base-c6/Makefile

Loading...
View Options

emulators/linux_base-f10/Makefile

Loading...
View Options

emulators/virtualbox-ose-additions/Makefile

Loading...
View Options

emulators/virtualbox-ose-kmod/Makefile

Loading...
View Options

finance/ledgersmb12/Makefile

Loading...
View Options

ftp/curl-hiphop/Makefile

Loading...
View Options

ftp/proftpd-mod_geoip/Makefile

Loading...
View Options

games/doom-data/Makefile

Loading...
View Options

games/ioquake3-devel-server/Makefile

Loading...
View Options

games/ioquake3-server/Makefile

Loading...
View Options

games/iourbanterror-server/Makefile

Loading...
View Options

games/linux-quake3/Makefile

Loading...
View Options

games/nethack33/Makefile

Loading...
View Options

games/openarena-server/Makefile

Loading...
View Options

games/opengfx/Makefile

Loading...
View Options

games/opensfx/Makefile

Loading...
View Options

games/quake-source/Makefile

Loading...
View Options

games/quake2-3zb2/Makefile

Loading...
View Options

games/quake2-ctf/Makefile

Loading...
View Options

games/quake2-data/Makefile

Loading...
View Options

games/quake2-extras/Makefile

Loading...
View Options

games/quake2-lights/Makefile

Loading...
View Options

games/quake2-matrix/Makefile

Loading...
View Options

games/quake2-psychomod/Makefile

Loading...
View Options

games/quake2-source/Makefile

Loading...
View Options

games/quake2-zaero/Makefile

Loading...
View Options

games/tuxpaint-fonts/Makefile

Loading...
View Options

games/xpilot-ng-server/Makefile

Loading...
View Options

graphics/frei0r-plugins/Makefile

Loading...
View Options

graphics/jgraph/Makefile

Loading...
View Options

graphics/libgnomecanvasmm26/Makefile

Loading...
View Options

graphics/py-aafigure/Makefile

Loading...
View Options

graphics/py-actdiag/Makefile

Loading...
View Options

graphics/py-blockdiag/Makefile

Loading...
View Options

graphics/py-imaging/Makefile

Loading...
View Options

graphics/py-nwdiag/Makefile

Loading...
View Options

graphics/py-seqdiag/Makefile

Loading...
View Options

graphics/py-webcolors/Makefile

Loading...
View Options

graphics/quat-gui/Makefile

Loading...
View Options

java/netty/Makefile

Loading...
View Options

java/openjdk6-jre/Makefile

Loading...
View Options

java/openjdk7-jre/Makefile

Loading...
View Options

java/openjdk7/Makefile

Loading...
View Options

lang/fpc-units/Makefile

Loading...
View Options

lang/gcc46/Makefile

Loading...
View Options

lang/gcc47/Makefile

Loading...
View Options

lang/gcc48/Makefile

Loading...
View Options

lang/gcc49/Makefile

Loading...
View Options

lang/gcc5-devel/Makefile

Loading...
View Options

lang/gcc5/Makefile

Loading...
View Options

lang/gcc6-devel/Makefile

Loading...
View Options

lang/php5/Makefile

Loading...
View Options

lang/php55/Makefile

Loading...
View Options

lang/php56/Makefile

Loading...
View Options

lang/ruby20/Makefile

Loading...
View Options

lang/ruby21/Makefile

Loading...
View Options

lang/ruby22/Makefile

Loading...
View Options

lang/tcl84/Makefile

Loading...
View Options

lang/tcl86/Makefile

Loading...
View Options

mail/addresses-goodies/Makefile

Loading...
View Options

mail/p5-IMAP-Admin/Makefile

Loading...
View Options

mail/popa3d/Makefile

Loading...
View Options

mail/qmail-ldap/Makefile

Loading...
View Options

mail/qmail-mysql/Makefile

Loading...
View Options

mail/qmail-spamcontrol/Makefile

Loading...
View Options

mail/qmail-tls/Makefile

Loading...
View Options

mail/wanderlust-devel/Makefile

Loading...
View Options

math/py-matplotlib/Makefile

Loading...
View Options

math/py-symeig/Makefile

Loading...
View Options

math/sage/Makefile

Loading...
View Options

math/vtk5/Makefile

Loading...
View Options

math/vtk6/Makefile

Loading...
View Options

misc/gnu-watch/Makefile

Loading...
View Options

misc/nut/Makefile

Loading...
View Options

misc/tellico-kde4/Makefile

Loading...
View Options

multimedia/gstreamer-qt4/Makefile

Loading...
View Options

multimedia/kplayer-kde4/Makefile

Loading...
View Options

net-im/kmess-kde4/Makefile

Loading...
View Options

net-im/py-xmpppy-yahoo/Makefile

Loading...
View Options

net-mgmt/netustad/Makefile

Loading...
View Options

net/freeradius3/Makefile

Loading...
View Options

net/hping-devel/Makefile

Loading...
View Options

net/isc-dhcp41-server/Makefile

Loading...
View Options

net/isc-dhcp42-server/Makefile

Loading...
View Options

net/isc-dhcp43-server/Makefile

Loading...
View Options

net/mosh/Makefile

Loading...
View Options

net/openmpi/Makefile

Loading...
View Options

net/proftpd-mod_ldap/Makefile

Loading...
View Options

net/samba36/Makefile

Loading...
View Options

news/inn/Makefile

Loading...
View Options

ports-mgmt/pkg-devel/Makefile

Loading...
View Options

ports-mgmt/pkg/Makefile

Loading...
View Options

print/cups-base/Makefile

Loading...
View Options

security/botan110/Makefile

Loading...
View Options

security/gag/Makefile

Loading...
View Options

security/krb5-111/Makefile

Loading...
View Options

security/krb5-112/Makefile

Loading...
View Options

security/krb5-appl/Makefile

Loading...
View Options

security/proftpd-mod_clamav/Makefile

Loading...
View Options

security/py-keyring/Makefile

Loading...
View Options

security/shibboleth2-sp/Makefile

Loading...
View Options

sysutils/backuppc-devel/Makefile

Loading...
View Options

sysutils/bacula-docs/Makefile

Loading...
View Options

sysutils/bacula5-docs/Makefile

Loading...
View Options

sysutils/boxbackup-devel/Makefile

Loading...
View Options

sysutils/cdrtools-devel/Makefile

Loading...
View Options

sysutils/cfengine32/Makefile

Loading...
View Options

sysutils/cfengine34/Makefile

Loading...
View Options

sysutils/cfengine36/Makefile

Loading...
View Options

sysutils/cfengine37/Makefile

Loading...
View Options

sysutils/knutclient-kde4/Makefile

Loading...
View Options

sysutils/pear-Log/Makefile

Loading...
View Options

textproc/apache-solr/Makefile

Loading...
View Options

textproc/flip/Makefile

Loading...
View Options

textproc/ruby-xmlscan/Makefile

Loading...
View Options

textproc/sphinxsearch-devel/Makefile

Loading...
View Options

www/apache22-event-mpm/Makefile

Loading...
View Options

www/apache22-itk-mpm/Makefile

Loading...
View Options

www/apache22-peruser-mpm/Makefile

Loading...
View Options

www/apache22-worker-mpm/Makefile

Loading...
View Options

www/autoindex2/Makefile

Loading...
View Options

www/cocoon/Makefile

Loading...
View Options

www/dillo2/Makefile

Loading...
View Options

www/free-sa-devel/Makefile

Loading...
View Options

www/geronimo/Makefile

Loading...
View Options

www/linux-opera/Makefile

Loading...
View Options

www/mod_auth_kerb2/Makefile

Loading...
View Options

www/mod_extract_forwarded/Makefile

Loading...
View Options

www/mod_layout22/Makefile

Loading...
View Options

www/mod_macro22/Makefile

Loading...
View Options

www/mod_myvhost/Makefile

Loading...
View Options

www/p5-Apache-Clean2/Makefile

Loading...
View Options

www/pear-HTTP_FloodControl/Makefile

Loading...
View Options

www/tdiary/Makefile

Loading...
View Options

www/xpi-adblock/Makefile.xpi

Loading...
View Options

x11-toolkits/tk84/Makefile

Loading...
View Options

x11-toolkits/tk85/Makefile

Loading...
View Options

x11-toolkits/tk86/Makefile

Loading...
View Options

x11-wm/afterstep/Makefile

Loading...
View Options

x11-wm/fvwm/Makefile

Loading...
View Options

x11-wm/fvwm2/Makefile

Loading...
View Options

x11-wm/xfce4/Makefile

Loading...
View Options

x11/rsibreak-kde4/Makefile

Loading...