Details

Reviewers

bapt
bdrewery

Group Reviewers

portmgr

Commits

rP394508: Remove UNIQUENAME and LATEST_LINK.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 18
Build 18: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 7769.Aug 7 2015, 9:26 PM

mat retitled this revision from to Remove UNIQUENAME..

mat updated this object.

mat edited the test plan for this revision. (Show Details)

Herald added a reviewer: portmgr. · View Herald TranscriptAug 7 2015, 9:26 PM

Please add a UNIQUENAME check in bsd.sanity.mk !

Remove NO_LATEST_LINK, it's a no-op.
Use PKGBASE instead of LATEST_LINK in PKGLATESTFILE, the *only* consumer
Remove obsolete documentation.
Remove LATEST_LINK.
Add UNIQUENAME and LATEST_LINK to the sanity checks.
Fix logic.
Remove UNIQUENAME.

Herald added reviewers: bapt, bdrewery. · View Herald TranscriptAug 8 2015, 9:22 AM

Herald added a project: pkg. · View Herald Transcript

mat edited edge metadata.Aug 8 2015, 9:24 AM

mat edited projects, added portmgr; removed pkg.

mat removed reviewers: bapt, bdrewery.

Maybe remove OPTIONSFILE code from Mk/bsd.port.mk and Makefiles too?

Now that UNIQUENAME is gone, OPTIONSFILE is too.

Herald added reviewers: bapt, bdrewery. · View Herald TranscriptAug 8 2015, 10:29 AM

Herald added a project: pkg. · View Herald Transcript

Rebase.

Herald edited edge metadata. · View Herald TranscriptAug 9 2015, 12:27 PM

Add a note about UNIQUENAME and LATEST_LINK removal.

Herald edited edge metadata. · View Herald TranscriptAug 11 2015, 10:53 AM

LGTM

needs an exp-run :-)

In D3336#68311, @antoine wrote:

needs an exp-run :-)

I think I'm through with the patch, feel free to run one :-)

There are 1 new failure and 2 new QA errors:

+ {"origin"=>"devel/php-memoize", "pkgname"=>"php-memoize-0.2.0b1_2", "phase"=>"fetch", "errortype"=>"distinfo_update"}
+ {"origin"=>"emulators/i386-wine-devel", "pkgname"=>"i386-wine-devel-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}
+ {"origin"=>"emulators/i386-wine-staging", "pkgname"=>"i386-wine-staging-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}

Error logs:

http://package22.nyi.freebsd.org/data/93i386-default-D3336/2015-08-13_09h42m29s/logs/errors/php-memoize-0.2.0b1_2.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-staging-1.7.48,1.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-devel-1.7.48,1.log

In D3336#68899, @antoine wrote:

There are 1 new failure and 2 new QA errors:

+ {"origin"=>"devel/php-memoize", "pkgname"=>"php-memoize-0.2.0b1_2", "phase"=>"fetch", "errortype"=>"distinfo_update"}
+ {"origin"=>"emulators/i386-wine-devel", "pkgname"=>"i386-wine-devel-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}
+ {"origin"=>"emulators/i386-wine-staging", "pkgname"=>"i386-wine-staging-1.7.48,1", "phase"=>"check-plist", "errortype"=>"PLIST"}

Error logs:

http://package22.nyi.freebsd.org/data/93i386-default-D3336/2015-08-13_09h42m29s/logs/errors/php-memoize-0.2.0b1_2.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-staging-1.7.48,1.log
http://pb2.nyi.freebsd.org/data/101amd64-default-D3336QAT/2015-08-13_09h43m35s/logs/errors/i386-wine-devel-1.7.48,1.log

Ok, fixed all those.

fix php-memoize sillyness.
Fix i386-wine-{devel,staging}

Herald edited edge metadata. · View Herald TranscriptAug 17 2015, 9:40 AM

Add warnings about options set with UNIQUENAME.

Herald edited edge metadata. · View Herald TranscriptAug 17 2015, 9:59 AM

Add a bit in UPDATING too.

Herald edited edge metadata. · View Herald TranscriptAug 17 2015, 10:09 AM

Closed by commit rP394508: Remove UNIQUENAME and LATEST_LINK. (authored by mat). · Explain WhyAug 17 2015, 2:21 PM

This revision was automatically updated to reflect the committed changes.

Remove UNIQUENAME.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7769

Mk/bsd.options.mk

Mk/bsd.port.mk

audio/lua51-mpd/Makefile

databases/mariadb-client/Makefile

databases/mariadb-scripts/Makefile

databases/mariadb-server/Makefile

databases/squirrel-sql/Makefile

deskutils/gworkspace-gwmetadata/Makefile

devel/cl-asdf/bsd.cl-asdf.mk

devel/llvm-cheri/Makefile

devel/llvm-devel/Makefile

devel/llvm33/Makefile

devel/llvm34/Makefile

devel/llvm35/Makefile

devel/llvm36/Makefile

devel/llvm37/Makefile

devel/ocaml-camlp5/Makefile

devel/php-memoize/Makefile

devel/py-funcparserlib/Makefile

dns/samba-nsupdate/Makefile

editors/2bsd-vi/Makefile

editors/libreoffice-i18n/Makefile

emulators/generator-cbiere/Makefile

emulators/i386-wine-devel/Makefile.inc

emulators/i386-wine/Makefile.inc

emulators/virtualbox-ose-additions/Makefile

emulators/virtualbox-ose-kmod/Makefile

games/ioquake3-devel-server/Makefile

games/ioquake3-server/Makefile

games/iourbanterror-server/Makefile

games/openarena-server/Makefile

games/xpilot-ng-server/Makefile

graphics/py-aafigure/Makefile

graphics/py-actdiag/Makefile

graphics/py-blockdiag/Makefile

graphics/py-imaging/Makefile

graphics/py-nwdiag/Makefile

graphics/py-seqdiag/Makefile

graphics/py-webcolors/Makefile

graphics/quat-gui/Makefile

java/netty/Makefile

java/openjdk6-jre/Makefile

lang/gcc46/Makefile

lang/gcc47/Makefile

lang/gcc48/Makefile

lang/gcc49/Makefile

lang/gcc5-devel/Makefile

lang/gcc5/Makefile

lang/gcc6-devel/Makefile

mail/addresses-goodies/Makefile

mail/p5-IMAP-Admin/Makefile

mail/popa3d/Makefile

math/py-matplotlib/Makefile

math/vtk5/Makefile

math/vtk6/Makefile

misc/gnu-watch/Makefile

misc/nut/Makefile

net-im/py-xmpppy-yahoo/Makefile

net/isc-dhcp41-server/Makefile

net/isc-dhcp42-server/Makefile

net/isc-dhcp43-server/Makefile

net/openmpi/Makefile

print/cups-base/Makefile

sysutils/bacula-docs/Makefile

sysutils/bacula5-docs/Makefile

www/linux-opera/Makefile

www/mod_extract_forwarded/Makefile

www/mod_myvhost/Makefile

www/tdiary/Makefile

Remove UNIQUENAME.
ClosedPublic
Actions

Revision Contents
Changeset List