Differential D26505

byacc: fix UBSAN shift range error
ClosedPublic
Actions

Authored by arichardson on Sep 21 2020, 9:48 AM.

Details

Reviewers

jkim

Commits

rS366075: byacc: fix UBSan signed shift range error

Summary

Not sure what the upstream for byacc is or how to submit this change here
so submitting this as a patch for contrib/

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 33700
Build 30936: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Sep 21 2020, 9:48 AM

arichardson created this revision.

Harbormaster completed remote builds in B33687: Diff 77285.Sep 21 2020, 9:48 AM

Add two more cases

Harbormaster completed remote builds in B33700: Diff 77317.Sep 21 2020, 7:43 PM

LGTM.

FYI, this is the upstream website:

https://invisible-island.net/byacc/byacc.html

You can find author's e-mail address from there. He is very responsive to this type of bug reports. :-)

This revision is now accepted and ready to land.Sep 22 2020, 1:48 PM

Closed by commit rS366075: byacc: fix UBSan signed shift range error (authored by arichardson). · Explain WhySep 23 2020, 12:55 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS366075: byacc: fix UBSan signed shift range error.

Herald added a subscriber: imp. · View Herald TranscriptSep 23 2020, 12:55 PM

Revision Contents
Changeset List

Path

Size

contrib/

byacc/

closure.c

4 lines

warshall.c

4 lines

Diff 77317

View Options

contrib/byacc/closure.c