fsx: fix build with WARNS=6
ClosedPublic
Actions

Authored by asomers on Sep 21 2020, 5:41 PM.

Tags

None

Referenced Files

	F163272434: D26516.id77309.diff
	Tue, Jul 21, 3:26 PM

	F163266959: D26516.id.diff
	Tue, Jul 21, 2:30 PM

	Unknown Object (File)
	Mon, Jul 20, 10:56 AM

	Unknown Object (File)
	Sat, Jul 18, 5:47 PM

	Unknown Object (File)
	Sat, Jul 4, 4:41 PM

	Unknown Object (File)
	Jun 13 2026, 11:36 PM

	Unknown Object (File)
	May 26 2026, 1:22 AM

	Unknown Object (File)
	May 9 2026, 12:43 AM

View All Files

Subscribers

imp

Details

Reviewers

kevans

Commits

rS368086: MFC r365956:
rS365956: fsx: fix build with WARNS=6

Summary

fsx: fix build with WARNS=6

signed/unsigned comparisons
use standard warn(3)
Suppress warnings about local vars and funcs not declared static
const-correctness
declaration shadows a variable in the global scope

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33698
Build 30934: arc lint + arc unit

Event Timeline

asomers created this revision.Sep 21 2020, 5:41 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2020, 5:41 PM

asomers requested review of this revision.Sep 21 2020, 5:41 PM

Harbormaster completed remote builds in B33698: Diff 77309.Sep 21 2020, 5:43 PM

kevans accepted this revision.Sep 21 2020, 5:46 PM

This revision is now accepted and ready to land.Sep 21 2020, 5:46 PM

Closed by commit rS365956: fsx: fix build with WARNS=6 (authored by asomers). · Explain WhySep 21 2020, 5:48 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS365956: fsx: fix build with WARNS=6.

asomers added a commit: rS368086: MFC r365956:.Nov 26 2020, 11:35 PM

Revision Contents
Changeset List

Path

Size

tools/

regression/

fsx/

Makefile

5 lines

fsx.c

63 lines

Diff 77309

View Options

tools/regression/fsx/Makefile