Move TDP_GEOM check to ast()
ClosedPublic
Actions

Authored by trasz on Sep 9 2020, 3:09 PM.

Details

Reviewers

kib
mav

Commits

rS365711: Move TDP_GEOM check from userret() to ast(); this code path is quite

Summary

Move TDP_GEOM check from userret() to ast(); it seems quite infrequent.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33458
Build 30740: arc lint + arc unit

Event Timeline

trasz created this revision.Sep 9 2020, 3:09 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 9 2020, 3:09 PM

trasz requested review of this revision.Sep 9 2020, 3:09 PM

Harbormaster completed remote builds in B33458: Diff 76812.Sep 9 2020, 3:09 PM

trasz added reviewers: kib, mav.Sep 9 2020, 3:09 PM

It is indeed infrequent. I can't say much about the ast() context, but I have no objections.

kib added inline comments.Sep 9 2020, 3:47 PM

sys/kern/subr_trap.c
291	I am slightly unsure about place to put this sleep. It is fine for now, we will see if things break.

kib accepted this revision.Sep 9 2020, 3:48 PM

This revision is now accepted and ready to land.Sep 9 2020, 3:48 PM

(Tinderboxed, Tested by: pho)

Closed by commit rS365711: Move TDP_GEOM check from userret() to ast(); this code path is quite (authored by trasz). · Explain WhySep 14 2020, 10:14 AM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS365711: Move TDP_GEOM check from userret() to ast(); this code path is quite.

Revision Contents
Changeset List

Path

Size

sys/

geom/

geom_event.c

3 lines

kern/

subr_trap.c

14 lines

Diff 76812

View Options

sys/geom/geom_event.c