Avoid collisions with function names in openssl headers.
ClosedPublic
Actions

Authored by stevek on Sep 4 2020, 2:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 3, 10:44 AM

	Unknown Object (File)
	Thu, Oct 23, 3:28 PM

	Unknown Object (File)
	Thu, Oct 23, 3:28 PM

	Unknown Object (File)
	Thu, Oct 23, 3:28 PM

	Unknown Object (File)
	Thu, Oct 23, 6:52 AM

	Unknown Object (File)
	Oct 19 2025, 8:06 AM

	Unknown Object (File)
	Oct 11 2025, 4:54 AM

	Unknown Object (File)
	Sep 20 2025, 2:44 PM

View All 89 Files

Subscribers

imp

Details

Reviewers

brooks
sjg

Commits

rS365325: Avoid collisions with function names in openssl headers.

Summary

Just using MD5, SHA1, RMD160 and SHA256 for defines collides with
functions of the same name in OpenSSL. This can cause compilation
issues in downstream consumers if they use OpenSSL for the hash
functions instead of libmd.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33377
Build 30681: arc lint + arc unit

Event Timeline

stevek created this revision.Sep 4 2020, 2:45 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 4 2020, 2:45 AM

stevek requested review of this revision.Sep 4 2020, 2:45 AM

Harbormaster completed remote builds in B33377: Diff 76634.Sep 4 2020, 2:45 AM

sjg accepted this revision.Sep 4 2020, 2:52 AM

This revision is now accepted and ready to land.Sep 4 2020, 2:52 AM

Closed by commit rS365325: Avoid collisions with function names in openssl headers. (authored by stevek). · Explain WhySep 4 2020, 4:32 AM

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rS365325: Avoid collisions with function names in openssl headers..

Revision Contents
Changeset List

Path

Size

usr.sbin/

fmtree/

Makefile

2 lines

compare.c

16 lines

Diff 76634

View Options

usr.sbin/fmtree/Makefile