Pass a valid mode with O_CREATE to open(2).
ClosedPublic
Actions

Authored by jhb on Sep 1 2020, 4:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 16, 7:51 PM

	Unknown Object (File)
	Sat, May 16, 7:51 PM

	Unknown Object (File)
	Sat, May 16, 7:48 PM

	Unknown Object (File)
	Sat, May 16, 2:31 PM

	Unknown Object (File)
	Tue, Apr 21, 8:53 AM

	Unknown Object (File)
	Mon, Apr 20, 2:58 PM

	Unknown Object (File)
	Apr 9 2026, 1:28 PM

	Unknown Object (File)
	Apr 8 2026, 11:58 PM

View All Files

Subscribers

imp

Details

Reviewers

brooks
ngie

Commits

rS365280: Pass a valid mode with O_CREATE to open(2).

Summary

This fixes various crashing tests under CheriABI.

Test Plan

run the sendfile_test tests under CHERI and verify still works post-fix under plain riscv64

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33303
Build 30623: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 1 2020, 4:42 PM

jhb created this revision.

Harbormaster completed remote builds in B33303: Diff 76502.Sep 1 2020, 4:42 PM

brooks accepted this revision.Sep 1 2020, 5:49 PM

This revision is now accepted and ready to land.Sep 1 2020, 5:49 PM

Closed by commit rS365280: Pass a valid mode with O_CREATE to open(2). (authored by jhb). · Explain WhySep 2 2020, 9:18 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS365280: Pass a valid mode with O_CREATE to open(2)..

Herald added a subscriber: imp. · View Herald TranscriptSep 2 2020, 9:18 PM

Macro lgtm:

Revision Contents
Changeset List

Path

Size

lib/

libc/

tests/

sys/

sendfile_test.c

12 lines

Diff 76502

View Options

lib/libc/tests/sys/sendfile_test.c

Pass a valid mode with O_CREATE to open(2).ClosedPublicActions