Differential D26247

Fix string overflow
ClosedPublic
Actions

Authored by trasz on Aug 31 2020, 1:54 PM.

Tags

None

Referenced Files

	F150820515: D26247.id76484.diff
	Sat, Apr 4, 6:55 AM

	Unknown Object (File)
	Tue, Mar 31, 2:12 PM

	Unknown Object (File)
	Tue, Mar 31, 12:30 AM

	Unknown Object (File)
	Thu, Mar 26, 9:44 AM

	Unknown Object (File)
	Thu, Mar 19, 12:18 PM

	Unknown Object (File)
	Wed, Mar 18, 11:52 PM

	Unknown Object (File)
	Tue, Mar 17, 6:12 AM

	Unknown Object (File)
	Mon, Mar 16, 1:32 PM

Subscribers

siderop1_netapp.com

Details

Reviewers

Commits

rS365040: Fix string overflow that could occur during redirection due to passing

Summary

Fix string overflow that could occur during redirection by passing
the right length to strlcpy(3). It looks like it could overflow
into the next field, isc_user, which is properly long to accomodate
for it; I don't think it could cause any harm other than breaking
the connection.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33251
Build 30586: arc lint + arc unit

Event Timeline

trasz created this revision.Aug 31 2020, 1:54 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2020, 1:54 PM

trasz requested review of this revision.Aug 31 2020, 1:54 PM

Harbormaster completed remote builds in B33251: Diff 76397.Aug 31 2020, 1:54 PM

trasz added a reviewer: mav.Aug 31 2020, 2:09 PM

trasz edited the summary of this revision. (Show Details)Aug 31 2020, 2:23 PM

mav accepted this revision.Aug 31 2020, 2:29 PM

This revision is now accepted and ready to land.Aug 31 2020, 2:29 PM

allanjude added a subscriber: siderop1_netapp.com.Aug 31 2020, 3:13 PM

Closed by commit rS365040: Fix string overflow that could occur during redirection due to passing (authored by trasz). · Explain WhySep 1 2020, 2:52 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS365040: Fix string overflow that could occur during redirection due to passing.

Revision Contents
Changeset List

Path

Size

usr.sbin/

iscsid/

2 lines

Diff 76397

usr.sbin/iscsid/login.c

Loading...