posixshm: fix setting of shm_flags
ClosedPublic
Actions

Authored by kevans on Aug 31 2020, 3:27 AM.

Details

Reviewers

kib
markj

Commits

rS364990: posixshm: fix setting of shm_flags

Summary

Noted in D24652, we currently set shmfd->shm_flags on every shm_open()/shm_open2(). This wasn't properly thought out; one shouldn't be able to specify incompatible flags on subsequent opens of non-anon shm.

Move setting of shm_flags explicitly to the two places shmfd are created, as we do with seals, and validate when we're opening a pre-existing mapping that we've either passed no flags or we've passed the exact same flags as the last time.

I'm unsure if it makes more sense to drop the 'shmfd->shm_flags != 0` condition and forcing the exact same flags on subsequent opens. That seems like it'd make it a little harder to use, and in theory specifying shmflags = 0 would be a sensible convention for "whatever was already established".

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 33247

Event Timeline

kevans created this revision.Aug 31 2020, 3:27 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2020, 3:27 AM

kevans requested review of this revision.Aug 31 2020, 3:27 AM

Harbormaster completed remote builds in B33247: Diff 76386.Aug 31 2020, 3:27 AM

(I won't be jumping to commit anything to avoid creating another merge conflict for the non-transparent super page patch)

This is fine, and it does not conflict with large pages patch.
More, there is a reason why I prefer to get this in before the final testing for large pages.

This revision is now accepted and ready to land.Aug 31 2020, 7:20 AM

markj accepted this revision.Aug 31 2020, 2:11 PM

Closed by commit rS364990: posixshm: fix setting of shm_flags (authored by kevans). · Explain WhyAug 31 2020, 3:07 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS364990: posixshm: fix setting of shm_flags.