Page MenuHomeFreeBSD
Differential D3286

Let the CloudABI futex code use umtx_keys.
ClosedPublic
Actions

Authored by ed on Aug 3 2015, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:51 PM
Unknown Object (File)
Thu, Dec 19, 4:06 PM
Unknown Object (File)
Thu, Dec 19, 12:36 PM
Unknown Object (File)
Thu, Nov 28, 3:51 AM
Unknown Object (File)
Thu, Nov 28, 3:50 AM
Unknown Object (File)
Thu, Nov 28, 3:48 AM
Unknown Object (File)
Oct 20 2024, 9:21 AM
Unknown Object (File)
Oct 20 2024, 4:32 AM
View All 81 Files
Subscribers
imp

Details

Reviewers
jhb
vangyzen
Commits
rS286278: Let the CloudABI futex code use umtx_keys.
Test Plan

The CloudABI kernel still passes all of the cloudlibc unit tests.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

ed updated this revision to Diff 7621.Aug 3 2015, 9:13 PM
ed retitled this revision from to Let the CloudABI futex code use umtx_keys..
ed updated this object.
ed edited the test plan for this revision. (Show Details)
ed added a reviewer: jhb.
Herald added a subscriber: imp. · View Herald TranscriptAug 3 2015, 9:13 PM
ed mentioned this in D3148: Add a futex implementation for CloudABI..Aug 3 2015, 9:16 PM
vangyzen added a reviewer: vangyzen.Aug 3 2015, 9:19 PM
vangyzen accepted this revision.Aug 3 2015, 10:02 PM
vangyzen edited edge metadata.
vangyzen added inline comments.
sys/compat/cloudabi/cloudabi_futex.c
221–225

umtx_key_get always operates on curthread. Here, td seems to always be curthread, but I didn't trace every call path. If this is true, you might assert it, if that doesn't seem too silly.

This revision is now accepted and ready to land.Aug 3 2015, 10:02 PM
ed updated this revision to Diff 7624.Aug 3 2015, 10:09 PM
ed edited edge metadata.

Add an assertion for the thread.

This revision now requires review to proceed.Aug 3 2015, 10:09 PM
ed added inline comments.Aug 3 2015, 10:12 PM
sys/compat/cloudabi/cloudabi_futex.c
221–225

That's a good idea. Done!

vangyzen accepted this revision.Aug 3 2015, 10:16 PM
vangyzen edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2015, 10:16 PM
Closed by commit rS286278: Let the CloudABI futex code use umtx_keys. (authored by ed). · Explain WhyAug 4 2015, 6:02 AM
This revision was automatically updated to reflect the committed changes.
jhb edited edge metadata.Aug 4 2015, 4:47 PM

Thanks!

Revision Contents
Changeset List

PathSize
sys/
compat/
cloudabi/
83 lines

Diff 7624

View Options

sys/compat/cloudabi/cloudabi_futex.c

Loading...