Page MenuHomeFreeBSD
Differential D3287

Fix bad arithmetic in umtx_key_get() to compute object offset.
ClosedPublic
Actions

Authored by ed on Aug 3 2015, 9:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 18, 9:28 PM
Unknown Object (File)
Wed, Mar 18, 3:24 AM
Unknown Object (File)
Mon, Mar 16, 10:33 PM
Unknown Object (File)
Sun, Mar 15, 4:00 AM
Unknown Object (File)
Thu, Mar 5, 12:49 PM
Unknown Object (File)
Fri, Feb 27, 11:35 AM
Unknown Object (File)
Feb 8 2026, 4:18 AM
Unknown Object (File)
Jan 30 2026, 11:38 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
jhb
Commits
rS286277: Fix bad arithmetic in umtx_key_get() to compute object offset.
Summary

It looks like umtx_key_get() has the addition and subtraction the wrong
way around, meaning that it fails to match in certain cases. This causes
the cloudlibc unit tests to deadlock in certain cases.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

ed updated this revision to Diff 7623.Aug 3 2015, 9:29 PM
ed retitled this revision from to Fix bad arithmetic in umtx_key_get() to compute object offset..
ed updated this object.
ed edited the test plan for this revision. (Show Details)
ed added reviewers: kib, jhb.
Herald added a subscriber: imp. · View Herald TranscriptAug 3 2015, 9:29 PM
kib accepted this revision.Aug 4 2015, 4:41 AM
kib edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2015, 4:41 AM
Closed by commit rS286277: Fix bad arithmetic in umtx_key_get() to compute object offset. (authored by ed). · Explain WhyAug 4 2015, 6:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 7623

View Options

sys/kern/kern_umtx.c

Loading...