Page MenuHomeFreeBSD
Differential D26054

linuxkpi: Add a few wait_bit functions
ClosedPublic
Actions

Authored by manu on Aug 13 2020, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 10:46 AM
Unknown Object (File)
Sun, Nov 3, 3:03 AM
Unknown Object (File)
Oct 26 2024, 4:48 AM
Unknown Object (File)
Oct 19 2024, 11:49 PM
Unknown Object (File)
Oct 18 2024, 1:35 AM
Unknown Object (File)
Oct 17 2024, 1:01 PM
Unknown Object (File)
Sep 28 2024, 3:21 PM
Unknown Object (File)
Sep 28 2024, 3:21 PM
View All 25 Files
Subscribers
imp

Details

Reviewers
• hselasky
emaste
Commits
rS364232: linuxkpi: Add a few wait_bit functions
Summary

The linux function does a lot more than that as multiple waitqueue could be fetch
from a static table based on the hash of the argument but since in DRM it's only used
in one place just add a single variable.
We will probably need to change that in the futur but it's ok with DRM even with current
linux.

Sponsored-by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu created this revision.Aug 13 2020, 10:03 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 13 2020, 10:03 AM
manu requested review of this revision.Aug 13 2020, 10:03 AM
• hselasky added inline comments.Aug 13 2020, 10:42 AM
sys/compat/linuxkpi/common/src/linux_compat.c
2495

Declare both of these in waitbit.h and include this header file instead of duplicating the extern declarations.

• hselasky added inline comments.Aug 13 2020, 10:43 AM
sys/compat/linuxkpi/common/src/linux_schedule.c
365

What about moving these simple declarations to waitbit.h as static inline functions?

manu updated this revision to Diff 75776.Aug 13 2020, 1:22 PM

Address hselasky@'s comments.

• hselasky added inline comments.Aug 13 2020, 1:33 PM
sys/compat/linuxkpi/common/src/linux_compat.c
89

#include <linux/waitbit.h>

Here ??

manu added inline comments.Aug 13 2020, 1:39 PM
sys/compat/linuxkpi/common/src/linux_compat.c
89

Why ? it's not needed

• hselasky added inline comments.Aug 13 2020, 9:16 PM
sys/compat/linuxkpi/common/src/linux_compat.c
89

Are you sure you have the prototype for those wait queues declared?

manu added inline comments.Aug 13 2020, 9:28 PM
sys/compat/linuxkpi/common/src/linux_compat.c
89

Yes

• hselasky added a comment.Aug 14 2020, 7:58 AM

Which header file does linux_compat.c include that includes wait_bit.h , I cannot see it?

manu added a comment.Aug 14 2020, 8:04 AM
In D26054#578431, @hselasky wrote:

Which header file does linux_compat.c include that includes wait_bit.h , I cannot see it?

Why do you want it to include wait_bit.h ? It doesn't uses any function from there.

• hselasky added a comment.Aug 14 2020, 8:11 AM

Hi, In wait_bit.h you have the prototypes:

extern wait_queue_head_t linux_bit_waitq;
extern wait_queue_head_t linux_var_waitq;

For:

wait_queue_head_t linux_bit_waitq;
wait_queue_head_t linux_var_waitq;

Even though the module compiles, I think it is most correct to have the extern's included before the declarations!

sys/compat/linuxkpi/common/src/linux_schedule.c
43

You can remove this include I guess.

manu added inline comments.Aug 14 2020, 8:22 AM
sys/compat/linuxkpi/common/src/linux_schedule.c
43

True, this one is a leftover.

manu updated this revision to Diff 75813.Aug 14 2020, 8:23 AM

Include wait_bit.h in compat.c, remove wait_bit.h from schedule.c

• hselasky accepted this revision.Aug 14 2020, 8:24 AM

Don't forget the put the word LinuxKPI in the commit message and MFC after.

This revision is now accepted and ready to land.Aug 14 2020, 8:24 AM
Closed by commit rS364232: linuxkpi: Add a few wait_bit functions (authored by manu). · Explain WhyAug 14 2020, 8:48 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rS364232: linuxkpi: Add a few wait_bit functions.
manu mentioned this in rS364674: MFC r363564-r363567, r363575, r363835-r363837, r363842-r363843, r364232.Aug 24 2020, 1:19 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
1 line
64 lines
src/
5 lines
1 line

Diff 75776

View Options

sys/compat/linuxkpi/common/include/linux/wait.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/wait_bit.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_schedule.c

Loading...