bectl_list: align column output for a mountpoint properly
ClosedPublic
Actions

Authored by rew on Aug 12 2020, 7:21 PM.

Details

Reviewers

allanjude
kevans

Commits

rS364369: bectl(8): Fix output of `bectl list` for the 'Mountpoint' column.

Summary

The output for bectl list is not aligned when the mounted property becomes a long enough
string.

Set the 'Mountpoint' column width based off the boot environment dataset with
the longest mounted property.

This addresses PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241064

Test Plan

All tests passed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32954
Build 30349: arc lint + arc unit

Event Timeline

rew created this revision.Aug 12 2020, 7:21 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 12 2020, 7:21 PM

rew requested review of this revision.Aug 12 2020, 7:21 PM

Harbormaster completed remote builds in B32954: Diff 75750.Aug 12 2020, 7:21 PM

rew added reviewers: allanjude, kevans.Aug 12 2020, 7:23 PM

LGTM; much improved.

Approved by: kevans (mentor)

This revision is now accepted and ready to land.Aug 14 2020, 8:29 PM

Closed by commit rS364369: bectl(8): Fix output of `bectl list` for the 'Mountpoint' column. (authored by rew). · Explain WhyAug 19 2020, 12:09 AM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rS364369: bectl(8): Fix output of `bectl list` for the 'Mountpoint' column..

Revision Contents
Changeset List

Path

Size

sbin/

bectl/

bectl_list.c

14 lines

Diff 75750

View Options

bectl_list: align column output for a mountpoint properlyClosedPublicActions