sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE
ClosedPublic
Actions

Authored by asomers on Aug 11 2020, 8:20 PM.

Details

Reviewers

freqlabs

Commits

rP544720: sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE

Summary

sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE

ports that need FreeBSD's src code should check $SRC_BASE rather than assume
/usr/src. For example, it should be possible to build openzfs-kmod with a
command like this:

env SRC_BASE=$HOME/freebsd/base/head make

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 32925
Build 30323: arc lint + arc unit

Event Timeline

asomers created this revision.Aug 11 2020, 8:20 PM

Herald added a subscriber: mat. · View Herald TranscriptAug 11 2020, 8:20 PM

asomers requested review of this revision.Aug 11 2020, 8:20 PM

Harbormaster completed remote builds in B32925: Diff 75699.Aug 11 2020, 8:20 PM

Shouldn't the USES=kmod bit handle this? Mk/Uses/kmod.mk

In D26033#577541, @freqlabs wrote:

Shouldn't the USES=kmod bit handle this? Mk/Uses/kmod.mk

It's supposed to. But USES=kmod sets the MAKE_ENV variable, not MAKE_OPTS. And using that in openzfs-kmod's Makefile breaks the build, presumably due to one or more of the other variables set by MAKE_ENV. That's probably why @kmoore wrote the port the way he did.

However, USES=kmod _does_ take care of the IGNORE warning. I'll remove that.

Don't duplicate USE=kmod's IGNORE warning

Harbormaster completed remote builds in B32929: Diff 75704.Aug 11 2020, 8:52 PM

If this works for you, it's fine with me.

This revision is now accepted and ready to land.Aug 11 2020, 9:57 PM

Closed by commit rP544720: sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE (authored by asomers). · Explain WhyAug 11 2020, 10:25 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rP544720: sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE.