Page MenuHomeFreeBSD

sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE
ClosedPublic

Authored by asomers on Aug 11 2020, 8:20 PM.

Details

Summary

sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE

ports that need FreeBSD's src code should check $SRC_BASE rather than assume
/usr/src. For example, it should be possible to build openzfs-kmod with a
command like this:

env SRC_BASE=$HOME/freebsd/base/head make

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Shouldn't the USES=kmod bit handle this? Mk/Uses/kmod.mk

Shouldn't the USES=kmod bit handle this? Mk/Uses/kmod.mk

It's supposed to. But USES=kmod sets the MAKE_ENV variable, not MAKE_OPTS. And using that in openzfs-kmod's Makefile breaks the build, presumably due to one or more of the other variables set by MAKE_ENV. That's probably why @kmoore wrote the port the way he did.

However, USES=kmod _does_ take care of the IGNORE warning. I'll remove that.

Don't duplicate USE=kmod's IGNORE warning

If this works for you, it's fine with me.

This revision is now accepted and ready to land.Aug 11 2020, 9:57 PM