New function in acpi subsystem: acpi_HasMethod()
Needs ReviewPublic
Actions

Authored by georg.lindenberg_web.de on Aug 9 2020, 3:08 PM.

Details

Reviewers

mav
jkim

Summary

acpi_HasMethod() checks if an acpi method exists within a given handle.
This function can be useful e.g. if we don't need a handle to the method.
E.g. one might want to check whether a hardware vendor has implemented
an optional acpi method or not.

It's a bit simpler and easier to read than acpi_GetHandleInScope().

There is a similar function in linux, acpi_has_method().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32887
Build 30289: arc lint + arc unit

Event Timeline

georg.lindenberg_web.de created this revision.Aug 9 2020, 3:08 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 9 2020, 3:08 PM

georg.lindenberg_web.de requested review of this revision.Aug 9 2020, 3:08 PM

Harbormaster completed remote builds in B32887: Diff 75625.Aug 9 2020, 3:08 PM

lwhsu added a reviewer: mav.Aug 11 2020, 4:16 PM

If you need it to simplify porting from Linux, then I have no objections. Otherwise it looks too trivial to me.

mav added a reviewer: jkim.Aug 11 2020, 5:10 PM

In D26013#577422, @mav wrote:

If you need it to simplify porting from Linux, then I have no objections. Otherwise it looks too trivial to me.

I agree with @mav. It is too trivial.

Thanks for reviewing.

I am fine with either outcome.
So in Linux acpi_has_method() is referenced in 26 files (https://elixir.bootlin.com/linux/v4.3/ident/acpi_has_method). Their equivalent of acpi_GetHandleInScope (acpi_get_handle) is referenced in 53 files. So there are some use-cases.

Another option would be to allow a NULL pointer in acpi_GetHandleInScope(), when we don't need a handle, really. But this might break existing code.

I leave it up to you. :-)