tput(1): Several enhancements for the manual page
ClosedPublic
Actions

Authored by gbe on Aug 8 2020, 1:31 PM.

Details

Reviewers

Group Reviewers

Commits

rS364338: MFC r364131: tput(1): Several enhancements for the manual page
rS364131: tput(1): Several enhancements for the manual page

Summary

tput(1): Several enhancements for the manual page

PR: 84670

Test Plan

mandoc output review and 'mandoc -Tlint' checks

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32876
Build 30279: arc lint + arc unit

Event Timeline

gbe requested review of this revision.Aug 8 2020, 1:31 PM

gbe created this revision.

Harbormaster completed remote builds in B32876: Diff 75609.Aug 8 2020, 1:31 PM

All good, thanks for taking care of it.

This revision is now accepted and ready to land.Aug 8 2020, 1:40 PM

Closed by commit rS364131: tput(1): Several enhancements for the manual page (authored by gbe). · Explain WhyAug 11 2020, 9:45 PM

This revision was automatically updated to reflect the committed changes.

gbe added a commit: rS364131: tput(1): Several enhancements for the manual page.

Herald added a subscriber: imp. · View Herald TranscriptAug 11 2020, 9:45 PM

gbe added a commit: rS364338: MFC r364131: tput(1): Several enhancements for the manual page.Aug 18 2020, 6:55 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

tput/

tput.1

63 lines

Diff 75609

View Options

usr.bin/tput/tput.1

	Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
	done			done

	umask 377			umask 377

	n=$(( ${entropy_save_num} - 1 ))			n=$(( ${entropy_save_num} - 1 ))
	while [ ${n} -ge 1 ]; do			while [ ${n} -ge 1 ]; do
	if [ -f "saved-entropy.${n}" ]; then			if [ -f "saved-entropy.${n}" ]; then
	mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"			mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
	elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then			elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
				delphijUnsubmitted Not Done Inline Actions fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync. delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
				cemAuthorUnsubmitted Done Inline Actions If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file. cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
	logger -is -t "$0" \			logger -is -t "$0" \
	"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \			"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
	it will not be rotated. Entropy file rotation is aborted.			it will not be rotated. Entropy file rotation is aborted.
	exit 1			exit 1
	fi			fi
	n=$(( ${n} - 1 ))			n=$(( ${n} - 1 ))
	done			done

	dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null			dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
				fsync saved-entropy.1 "."
				delphijUnsubmitted Done Inline Actions This can be merged with the '.' (fsync saved-entropy.1 .). delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
				cemAuthorUnsubmitted Done Inline Actions Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it. cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

	exit 0			exit 0

tput(1): Several enhancements for the manual pageClosedPublicActions