Page MenuHomeFreeBSD
Differential D25956

iommu_domain constructor
ClosedPublic
Actions

Authored by br on Aug 5 2020, 12:36 PM.
Tags
None
Referenced Files
F174646278: D25956.id75450.diff
Sun, Oct 4, 10:17 PM
F174646136: D25956.id75474.diff
Sun, Oct 4, 10:16 PM
F174612661: D25956.diff
Sun, Oct 4, 4:32 PM
Unknown Object (File)
Wed, Sep 23, 1:19 AM
Unknown Object (File)
Sun, Sep 20, 4:09 PM
Unknown Object (File)
Sun, Sep 20, 3:56 PM
Unknown Object (File)
Sun, Sep 20, 3:54 PM
Unknown Object (File)
Sun, Sep 20, 2:06 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS363946: Add iommu_domain constructor and destructor.
Summary

Add iommu_domain constructor and destructor.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.Aug 5 2020, 12:36 PM
br created this revision.
kib added inline comments.Aug 5 2020, 2:56 PM
sys/dev/iommu/busdma_iommu.c
1073 ↗(On Diff #75423)

I suggest to pass iommu_unit, and map_ops as the arguments.

1079 ↗(On Diff #75423)

What about unload_task ?

br updated this revision to Diff 75450.Aug 5 2020, 9:03 PM

Pass ops and iommu_unit to iommu_domain_init()

br added inline comments.Aug 5 2020, 9:04 PM
sys/dev/iommu/busdma_iommu.c
1079 ↗(On Diff #75423)

may be we should move dmar_domain_unload_task() to busdma_iommu.c in the next diff

kib accepted this revision.Aug 5 2020, 9:42 PM
kib added inline comments.
sys/dev/iommu/busdma_iommu.c
1079 ↗(On Diff #75423)

I do not see a reason not to, but lets see the diff.

This revision is now accepted and ready to land.Aug 5 2020, 9:42 PM
Closed by commit rS363946: Add iommu_domain constructor and destructor. (authored by br). · Explain WhyAug 6 2020, 8:48 AM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363946: Add iommu_domain constructor and destructor..
Herald added a subscriber: imp. · View Herald TranscriptAug 6 2020, 8:48 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iommu/
20 lines
3 lines
x86/
iommu/
16 lines
2 lines
11 lines

Diff 75474

View Options

head/sys/dev/iommu/busdma_iommu.c

Loading...
View Options

head/sys/dev/iommu/iommu.h

Loading...
View Options

head/sys/x86/iommu/intel_ctx.c

Loading...
View Options

head/sys/x86/iommu/intel_dmar.h

Loading...
View Options

head/sys/x86/iommu/intel_idpgtbl.c

Loading...