Page MenuHomeFreeBSD
Differential D25956

iommu_domain constructor
ClosedPublic
Actions

Authored by br on Aug 5 2020, 12:36 PM.
Tags
None
Referenced Files
F170748639: D25956.id75423.diff
Sun, Sep 6, 9:47 AM
F170631002: D25956.id.diff
Sat, Sep 5, 5:40 PM
F170630963: D25956.id.diff
Sat, Sep 5, 5:40 PM
Unknown Object (File)
Sat, Sep 5, 8:54 AM
Unknown Object (File)
Fri, Sep 4, 10:35 AM
Unknown Object (File)
Fri, Sep 4, 10:35 AM
Unknown Object (File)
Fri, Sep 4, 5:02 AM
Unknown Object (File)
Thu, Sep 3, 11:33 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS363946: Add iommu_domain constructor and destructor.
Summary

Add iommu_domain constructor and destructor.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Aug 5 2020, 12:36 PM
br created this revision.
kib added inline comments.Aug 5 2020, 2:56 PM
sys/dev/iommu/busdma_iommu.c
1068

I suggest to pass iommu_unit, and map_ops as the arguments.

1074

What about unload_task ?

br updated this revision to Diff 75450.Aug 5 2020, 9:03 PM

Pass ops and iommu_unit to iommu_domain_init()

br added inline comments.Aug 5 2020, 9:04 PM
sys/dev/iommu/busdma_iommu.c
1074

may be we should move dmar_domain_unload_task() to busdma_iommu.c in the next diff

kib accepted this revision.Aug 5 2020, 9:42 PM
kib added inline comments.
sys/dev/iommu/busdma_iommu.c
1074

I do not see a reason not to, but lets see the diff.

This revision is now accepted and ready to land.Aug 5 2020, 9:42 PM
Closed by commit rS363946: Add iommu_domain constructor and destructor. (authored by br). · Explain WhyAug 6 2020, 8:48 AM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363946: Add iommu_domain constructor and destructor..
Herald added a subscriber: imp. · View Herald TranscriptAug 6 2020, 8:48 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
iommu/
20 lines
3 lines
x86/
iommu/
16 lines
2 lines
11 lines

Diff 75450

View Options

sys/dev/iommu/busdma_iommu.c

Loading...
View Options

sys/dev/iommu/iommu.h

Loading...
View Options

sys/x86/iommu/intel_ctx.c

Loading...
View Options

sys/x86/iommu/intel_dmar.h

Loading...
View Options

sys/x86/iommu/intel_idpgtbl.c

Loading...