Differential D25943

linuxkpi: Add clear_bit_unlock
ClosedPublic
Actions

Authored by manu on Aug 4 2020, 10:50 AM.

Details

Reviewers

• hselasky

Commits

rS363842: linuxkpi: Add clear_bit_unlock

Summary

This calls clear_bit and adds a memory barrier.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Aug 4 2020, 10:50 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptAug 4 2020, 10:50 AM

manu requested review of this revision.Aug 4 2020, 10:50 AM

• hselasky added inline comments.Aug 4 2020, 11:00 AM

sys/compat/linuxkpi/common/include/linux/bitops.h
281	extra space after bit and before ,

style(9)

Add the word LinuxKPI to the commit message, and don't forget to MFC.

This revision is now accepted and ready to land.Aug 4 2020, 3:17 PM

Closed by commit rS363842: linuxkpi: Add clear_bit_unlock (authored by manu). · Explain WhyAug 4 2020, 3:25 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS363842: linuxkpi: Add clear_bit_unlock.

manu mentioned this in rS364674: MFC r363564-r363567, r363575, r363835-r363837, r363842-r363843, r364232.Aug 24 2020, 1:19 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

bitops.h

7 lines

Diff 75355

View Options

sys/compat/linuxkpi/common/include/linux/bitops.h

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 Lines	FBSD_1.0 {
fchdir;		fchdir;
fchflags;		fchflags;
fchmod;		fchmod;
fchown;		fchown;
fcntl;		fcntl;
fhopen;		fhopen;
flock;		flock;
fork;		fork;
fpathconf;		fpathconf;
		kibUnsubmitted Done Inline Actions Add context to the diff. Even without the context, I am sure that you put the symbols into the wrong namespace. kib: Add context to the diff. Even without the context, I am sure that you put the symbols into the…
		jack_gandi.netAuthorUnsubmitted Done Inline Actions Should I add a FBSD_1.6 section then? jack_gandi.net: Should I add a FBSD_1.6 section then?
		jack_gandi.netAuthorUnsubmitted Done Inline Actions nevermind, I just realized https://wiki.freebsd.org/AddingSyscalls says to put them in the most recent namespace (FBSD_1.5) jack_gandi.net: nevermind, I just realized https://wiki.freebsd.org/AddingSyscalls says to put them in the most…
fsync;		fsync;
futimes;		futimes;
getaudit;		getaudit;
getaudit_addr;		getaudit_addr;
getauid;		getauid;
getcontext;		getcontext;
getdtablesize;		getdtablesize;
getegid;		getegid;
▲ Show 20 Lines • Show All 285 Lines • ▼ Show 20 Lines	FBSD_1.5 {
fdatasync;		fdatasync;
fhstat;		fhstat;
fhstatfs;		fhstatfs;
fstat;		fstat;
fstatat;		fstatat;
fstatfs;		fstatfs;
getdents;		getdents;
getdirentries;		getdirentries;
getfsstat;		getfsstat;
		kibUnsubmitted Not Done Inline Actions No, FBSD_1.5 is wrong again. New 13-CURRENT symbols must go into FBSD_1.6. kib: No, FBSD_1.5 is wrong again. New 13-CURRENT symbols must go into FBSD_1.6.
getrandom;		getrandom;
kevent;		kevent;
lstat;		lstat;
mknod;		mknod;
mknodat;		mknodat;
stat;		stat;
statfs;		statfs;
cpuset_getdomain;		cpuset_getdomain;
cpuset_setdomain;		cpuset_setdomain;
};		};

		FBSD_1.6 {
		fhlink;
		fhlinkat;
		fhreadlink;
		getfhat;
		};

FBSDprivate_1.0 {		FBSDprivate_1.0 {
___acl_aclcheck_fd;		___acl_aclcheck_fd;
__sys___acl_aclcheck_fd;		__sys___acl_aclcheck_fd;
___acl_aclcheck_file;		___acl_aclcheck_file;
__sys___acl_aclcheck_file;		__sys___acl_aclcheck_file;
___acl_aclcheck_link;		___acl_aclcheck_link;
__sys___acl_aclcheck_link;		__sys___acl_aclcheck_link;
___acl_delete_fd;		___acl_delete_fd;
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Lines	FBSDprivate_1.0 {
__sys_fchown;		__sys_fchown;
_fcntl;		_fcntl;
__sys_fcntl;		__sys_fcntl;
__fcntl_compat;		__fcntl_compat;
_fhopen;		_fhopen;
__sys_fhopen;		__sys_fhopen;
_fhstat;		_fhstat;
__sys_fhstat;		__sys_fhstat;
_fhstatfs;		_fhstatfs;
		brooksUnsubmitted Done Inline Actions I believe it's unnecessary to add these as there are no potential consumers of these symbols. brooks: I believe it's unnecessary to add these as there are no potential consumers of these symbols.
__sys_fhstatfs;		__sys_fhstatfs;
_flock;		_flock;
__sys_flock;		__sys_flock;
_fork;		_fork;
__sys_fork;		__sys_fork;
_fpathconf;		_fpathconf;
__sys_fpathconf;		__sys_fpathconf;
_fstat;		_fstat;
▲ Show 20 Lines • Show All 443 Lines • Show Last 20 Lines

linuxkpi: Add clear_bit_unlockClosedPublicActions