Page MenuHomeFreeBSD
Differential D25878

Remove headers from iommu.h
ClosedPublic
Actions

Authored by br on Jul 29 2020, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 2, 2:19 AM
Unknown Object (File)
Wed, Apr 1, 7:46 AM
Unknown Object (File)
Sat, Mar 28, 11:27 AM
Unknown Object (File)
Sat, Mar 28, 3:33 AM
Unknown Object (File)
Wed, Mar 25, 6:12 AM
Unknown Object (File)
Tue, Mar 24, 5:43 PM
Unknown Object (File)
Tue, Mar 24, 5:30 PM
Unknown Object (File)
Tue, Mar 24, 4:37 AM
View All Files
Subscribers
cy
imp

Details

Reviewers
kib
Commits
rS363675: o Don't include headers from iommu.h, include them from the header
Summary

Remove headers from iommu.h

Test Plan

boot amd64

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Jul 29 2020, 1:43 PM
br created this revision.
kib added inline comments.Jul 29 2020, 2:52 PM
sys/dev/iommu/iommu_gas.c
71–72

This is quite weird #ifdef block. Why pci and iommu are under ifdef ?

sys/x86/iommu/intel_drv.c
68–73

I propose to make the order of headers consistent. Put dev/pci right after vm/, then dev/iommu, then x86 headers.

kib mentioned this in D25879: Fix modules build.Jul 29 2020, 2:53 PM
br added inline comments.Jul 29 2020, 3:51 PM
sys/x86/iommu/intel_drv.c
68–73

dev/iommu/busdma_iommu.h depends on struct bus_dma_tag_common, which is defined in x86/include/busdma_impl.h.
so x86 header should go first ?

cy added a subscriber: cy.Jul 29 2020, 5:04 PM
kib added inline comments.Jul 29 2020, 7:06 PM
sys/x86/iommu/intel_drv.c
68–73

Might be. What provides a similar common structure on arm64 ?

br updated this revision to Diff 75144.Jul 29 2020, 9:13 PM

Fix order of headers:
sys/vm/contrib/dev/machine/x86

br added inline comments.Jul 29 2020, 9:15 PM
sys/x86/iommu/intel_drv.c
68–73

arm64/include/bus_dma_impl.h

kib accepted this revision.Jul 29 2020, 9:48 PM
This revision is now accepted and ready to land.Jul 29 2020, 9:48 PM
Closed by commit rS363675: o Don't include headers from iommu.h, include them from the header (authored by br). · Explain WhyJul 29 2020, 10:09 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363675: o Don't include headers from iommu.h, include them from the header.
Herald added a subscriber: imp. · View Herald TranscriptJul 29 2020, 10:09 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
iommu/
8 lines
8 lines
ntb/
ntb_hw/
2 lines
2 lines
x86/
iommu/
10 lines
16 lines
4 lines
11 lines
12 lines
14 lines
6 lines

Diff 75144

View Options

sys/dev/iommu/iommu.h

Loading...
View Options

sys/dev/iommu/iommu_gas.c

Loading...
View Options

sys/dev/ntb/ntb_hw/ntb_hw_intel.c

Loading...
View Options

sys/dev/ntb/ntb_hw/ntb_hw_plx.c

Loading...
View Options

sys/x86/iommu/intel_ctx.c

Loading...
View Options

sys/x86/iommu/intel_drv.c

Loading...
View Options

sys/x86/iommu/intel_idpgtbl.c

Loading...
View Options

sys/x86/iommu/intel_intrmap.c

Loading...
View Options

sys/x86/iommu/intel_qi.c

Loading...
View Options

sys/x86/iommu/intel_quirks.c

Loading...
View Options

sys/x86/iommu/intel_utils.c

Loading...