Add myself (rew) as a src committer
ClosedPublic
Actions

Authored by rew on Jul 27 2020, 9:29 PM.

Details

Reviewers

kevans
allanjude

Commits

rS363659: Add myself (rew) as src committer.

Summary

added mentor/mentee relationship

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.Jul 27 2020, 9:29 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2020, 9:29 PM

rew requested review of this revision.Jul 27 2020, 9:29 PM

Harbormaster completed remote builds in B32590: Diff 75027.Jul 27 2020, 9:29 PM

Approved by: kevans (mentor)

This revision is now accepted and ready to land.Jul 28 2020, 6:36 PM

Approved By: allanjude (mentor)

Closed by commit rS363659: Add myself (rew) as src committer. (authored by rew). · Explain WhyJul 29 2020, 5:27 AM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rS363659: Add myself (rew) as src committer..

Revision Contents
Changeset List

Path

Size

head/

share/

misc/

committers-src.dot

4 lines

Diff 75105

View Options

head/share/misc/committers-src.dot

Context not available.
	regs[0] = leaf + 1;	regs[0] = leaf + 1;

	if (regs[0] >= leaf) {	if (regs[0] >= leaf) {
		enum VM_GUEST prev_vm_guest = vm_guest;

	for (i = 0; i < nitems(vm_cpuids); i++)	for (i = 0; i < nitems(vm_cpuids); i++)
	if (strncmp((const char *)&regs[1],	if (strncmp((const char *)&regs[1],
	vm_cpuids[i].vm_cpuid, 12) == 0) {	vm_cpuids[i].vm_cpuid, 12) == 0) {
Context not available.
	* specific hypervisor, record the base, high value,	* specific hypervisor, record the base, high value,
	* and vendor identifier.	* and vendor identifier.
	*/	*/
	if (vm_guest != VM_GUEST_VM \|\| leaf == 0x40000000) {	if (vm_guest != prev_vm_guest \|\| leaf == 0x40000000) {
	hv_base = leaf;	hv_base = leaf;
	hv_high = regs[0];	hv_high = regs[0];
	((u_int *)&hv_vendor)[0] = regs[1];	((u_int *)&hv_vendor)[0] = regs[1];
Context not available.
	* If we found a specific hypervisor, then	* If we found a specific hypervisor, then
	* we are finished.	* we are finished.
	*/	*/
	if (vm_guest != VM_GUEST_VM)	if (vm_guest != VM_GUEST_VM &&
		/*
		* Xen and other hypervisors can expose the
		* HyperV signature in addition to the
		* native one in order to support Viridian
		* extensions for Windows guests.
		*
		* Do the full cpuid scan if HyperV is
		* detected, as the native hypervisor is
		* preferred.
		markjUnsubmitted Not Done Inline Actions Do you need to modify the enclosing if statement as well? I think it assumes that `vm_guest` will only be assigned once. markj: Do you need to modify the enclosing if statement as well? I think it assumes that `vm_guest`…
		roygerAuthorUnsubmitted Done Inline Actions bah, indeed, or else it will update the cached leaf even if no hypervisor was found. Will update the diff. royger: bah, indeed, or else it will update the cached leaf even if no hypervisor was found. Will…
		*/
		vm_guest != VM_GUEST_HV)
	return;	return;
	}	}
	}	}
Context not available.

Add myself (rew) as a src committerClosedPublicActions