Paths

Table of Contentst

Add entry for new doc commiter
ClosedPublic
Actions

Authored by debdrup on Jul 28 2020, 1:43 PM.

Details

Reviewers

0mp
allanjude
bcr

Group Reviewers

docs

Commits

rD54383: Add news entry for new doc commiter

Summary

As part of onboarding, announce my doc commit bit.

Test Plan

Igor'ing

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 32607
Build 30063: arc lint + arc unit

Event Timeline

debdrup requested review of this revision.Jul 28 2020, 1:43 PM

debdrup created this revision.

Harbormaster completed remote builds in B32607: Diff 75060.Jul 28 2020, 1:43 PM

0mp requested changes to this revision.Jul 28 2020, 2:04 PM

0mp added inline comments.

share/xml/news.xml
41	I am not sure, bu most entries seem to put `</p>` on the same line as the end of the text.

This revision now requires changes to proceed.Jul 28 2020, 2:04 PM

bcr added inline comments.Jul 28 2020, 2:17 PM

share/xml/news.xml
41	Yes, that's how it's done. You need to move it right after the "(doc)" part to close the paragraph.

Fix errant newline

Thanks for catching this :)

Harbormaster completed remote builds in B32613: Diff 75067.Jul 28 2020, 2:37 PM

debdrup marked 2 inline comments as done.Jul 28 2020, 2:37 PM

Approved By: allanjude (mentor)

0mp accepted this revision.Jul 29 2020, 10:22 AM

This revision is now accepted and ready to land.Jul 29 2020, 10:22 AM

Closed by commit rD54383: Add news entry for new doc commiter (authored by debdrup). · Explain WhyJul 29 2020, 11:10 AM

This revision was automatically updated to reflect the committed changes.

debdrup added a commit: rD54383: Add news entry for new doc commiter.

Revision Contents
Changeset List

Path

Size

share/

xml/

news.xml

10 lines

Diff 75060

View Options

Add entry for new doc commiterClosedPublicActions