Page MenuHomeFreeBSD
Differential D25768

ntb: Stop checking for failures from malloc(M_WAITOK).
ClosedPublic
Actions

Authored by markj on Jul 22 2020, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 4:18 PM
Unknown Object (File)
Mar 15 2025, 4:08 AM
Unknown Object (File)
Mar 5 2025, 9:24 PM
Unknown Object (File)
Mar 4 2025, 3:31 PM
Unknown Object (File)
Mar 4 2025, 3:24 PM
Unknown Object (File)
Feb 24 2025, 4:33 AM
Unknown Object (File)
Jan 27 2025, 6:57 AM
Unknown Object (File)
Jan 24 2025, 4:56 PM
View All 94 Files
Subscribers
imp

Details

Reviewers
cem
mav
Commits
rS363445: ntb: Stop checking for failures from malloc(M_WAITOK).
Summary

PR: 240545
Submitted by: Andrew Reiter <arr@watson.org>
MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ntb/
test/
29 lines

Diff 74841

View Options

head/sys/dev/ntb/test/ntb_tool.c

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
static void add_compunit(enum e_cut, char *); static void add_compunit(enum e_cut, char *);
static void add_file(char *); static void add_file(char *);
static void usage(void); static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int c, fflag; int c, fflag, fflagstdin;
char *temp_arg; char *temp_arg;
(void) setlocale(LC_ALL, ""); (void) setlocale(LC_ALL, "");
fflag = 0; fflag = 0;
fflagstdin = 0;
inplace = NULL; inplace = NULL;
while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1) while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1)
switch (c) { switch (c) {
case 'r': /* Gnu sed compat */ case 'r': /* Gnu sed compat */
case 'E': case 'E':
rflags = REG_EXTENDED; rflags = REG_EXTENDED;
break; break;
Show All 9 Lines case 'e':
if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL) if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL)
err(1, "malloc"); err(1, "malloc");
strcpy(temp_arg, optarg); strcpy(temp_arg, optarg);
strcat(temp_arg, "\n"); strcat(temp_arg, "\n");
add_compunit(CU_STRING, temp_arg); add_compunit(CU_STRING, temp_arg);
break; break;
case 'f': case 'f':
fflag = 1; fflag = 1;
if (strcmp(optarg, "-") == 0)
fflagstdin = 1;
add_compunit(CU_FILE, optarg); add_compunit(CU_FILE, optarg);
break; break;
case 'i': case 'i':
inplace = optarg; inplace = optarg;
ispan = 0; /* don't span across input files */ ispan = 0; /* don't span across input files */
break; break;
case 'l': case 'l':
if(setvbuf(stdout, NULL, _IOLBF, 0) != 0) if(setvbuf(stdout, NULL, _IOLBF, 0) != 0)
Show All 20 Linesmain(int argc, char *argv[])
} }
compile(); compile();
/* Continue with first and start second usage */ /* Continue with first and start second usage */
if (*argv) if (*argv)
for (; *argv; argv++) for (; *argv; argv++)
add_file(*argv); add_file(*argv);
else if (fflagstdin)
0mpAuthorUnsubmitted
Done
Inline Actions

There has to be at least one input file specified.

0mp: There has to be at least one input file specified.
exit(rval);
else else
add_file(NULL); add_file(NULL);
process(); process();
cfclose(prog, NULL); cfclose(prog, NULL);
if (fclose(stdout)) if (fclose(stdout))
err(1, "stdout"); err(1, "stdout");
exit(rval); exit(rval);
} }
Show All 27 Lines case ST_EOF:
if (script == NULL) { if (script == NULL) {
if (more != NULL) if (more != NULL)
*more = 0; *more = 0;
return (NULL); return (NULL);
} }
linenum = 0; linenum = 0;
switch (script->type) { switch (script->type) {
case CU_FILE: case CU_FILE:
if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)
0mpAuthorUnsubmitted
Done
Inline Actions

I am not sure if it makes any difference if I try to avoid depending on the presence of /dev/stdin by using the 0th descriptor here instead.

0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
tobikUnsubmitted
Done
Inline Actions

Can this not just be f = stdin?

tobik: Can this not just be `f = stdin`?
0mpAuthorUnsubmitted
Done
Inline Actions

Good catch! The tests are still passing.

0mp: Good catch! The tests are still passing.
fname = "stdin";
0mpAuthorUnsubmitted
Done
Inline Actions

Is stdin name here alright? Perhaps it could be changed to -?

0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
} else {
if ((f = fopen(script->s, "r")) == NULL) if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s); err(1, "%s", script->s);
fname = script->s; fname = script->s;
}
state = ST_FILE; state = ST_FILE;
goto again; goto again;
case CU_STRING: case CU_STRING:
if (((size_t)snprintf(string_ident, if (((size_t)snprintf(string_ident,
sizeof(string_ident), "\"%s\"", script->s)) >= sizeof(string_ident), "\"%s\"", script->s)) >=
sizeof(string_ident) - 1) sizeof(string_ident) - 1)
(void)strcpy(string_ident + (void)strcpy(string_ident +
sizeof(string_ident) - 6, " ...\""); sizeof(string_ident) - 6, " ...\"");
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines