Page MenuHomeFreeBSD
Differential D25766

mpr(4), mps(4): Stop checking for failures from malloc(M_WAITOK).
ClosedPublic
Actions

Authored by markj on Jul 22 2020, 3:13 PM.
Tags
None
Referenced Files
F114933188: D25766.id74791.diff
Fri, Apr 18, 5:39 PM
Unknown Object (File)
Sun, Apr 6, 12:56 PM
Unknown Object (File)
Mar 8 2025, 3:43 PM
Unknown Object (File)
Mar 5 2025, 7:44 AM
Unknown Object (File)
Mar 4 2025, 5:49 PM
Unknown Object (File)
Mar 4 2025, 9:51 AM
Unknown Object (File)
Mar 3 2025, 5:39 PM
Unknown Object (File)
Mar 2 2025, 4:00 PM
View All 49 Files
Subscribers
None

Details

Reviewers
slm
scottl
imp
Commits
rS363608: mpr(4), mps(4): Stop checking for failures from malloc(M_WAITOK).
Summary

PR: 240545
Submitted by: Andrew Reiter <arr@watson.org>
MFC after: 1 week

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32477
Build 29953: arc lint + arc unit

Event Timeline

markj created this revision.Jul 22 2020, 3:13 PM
Herald added a reviewer: slm. · View Herald TranscriptJul 22 2020, 3:13 PM
markj requested review of this revision.Jul 22 2020, 3:13 PM
Harbormaster completed remote builds in B32477: Diff 74791.Jul 22 2020, 3:13 PM
markj added reviewers: scottl, imp.Jul 22 2020, 3:14 PM
imp accepted this revision.Jul 22 2020, 3:34 PM

These all look good to me. Might want to wait a little on Scott since this is semivendor code and there may a hidden reason for these...

This revision is now accepted and ready to land.Jul 22 2020, 3:34 PM
Closed by commit rS363608: mpr(4), mps(4): Stop checking for failures from malloc(M_WAITOK). (authored by markj). · Explain WhyJul 27 2020, 2:29 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS363608: mpr(4), mps(4): Stop checking for failures from malloc(M_WAITOK)..
scottl added a comment.Jul 31 2020, 11:10 PM

Whatever reason there was for either using M_WAITOK or for checking for failure are lost to time.

Revision Contents
Changeset List

PathSize
sys/
dev/
mpr/
9 lines
15 lines
7 lines
mps/
8 lines
15 lines
7 lines

Diff 74791

View Options

sys/dev/mpr/mpr.c

Loading...
View Options

sys/dev/mpr/mpr_sas.c

Loading...
View Options

sys/dev/mpr/mpr_user.c

Loading...
View Options

sys/dev/mps/mps.c

Loading...
View Options

sys/dev/mps/mps_sas.c

Loading...
View Options

sys/dev/mps/mps_user.c

Loading...