Page MenuHomeFreeBSD
Differential D3216

Limit ofw_cpu_early_foreach to CPUs only
ClosedPublic
Actions

Authored by wma_semihalf.com on Jul 27 2015, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 9, 7:55 PM
Unknown Object (File)
Wed, Nov 5, 6:12 PM
Unknown Object (File)
Tue, Nov 4, 4:16 PM
Unknown Object (File)
Tue, Nov 4, 4:16 PM
Unknown Object (File)
Tue, Nov 4, 1:50 PM
Unknown Object (File)
Tue, Nov 4, 1:49 PM
Unknown Object (File)
Tue, Nov 4, 10:06 AM
Unknown Object (File)
Thu, Oct 30, 12:29 PM
View All Files
Subscribers
imp

Details

Reviewers
nwhitehorn
zbb
emaste
andrew
Commits
rS285957: Limit ofw_cpu_early_foreach() to CPUs only
Summary

On some platforms, the /cpus entry contains cpu-to-cluster
map which deffinitely is not a CPU device. Its presence was
causing incrementing of "id" variable and reporting more
CPUs available than it should.
To make "id" valid, increment it only when an entry really
is a CPU.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wma_semihalf.com updated this revision to Diff 7370.Jul 27 2015, 8:02 AM
wma_semihalf.com retitled this revision from to Limit ofw_cpu_early_foreach to CPUs only.
wma_semihalf.com updated this object.
wma_semihalf.com edited the test plan for this revision. (Show Details)
wma_semihalf.com added reviewers: andrew, zbb, nwhitehorn, emaste.
wma_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJul 27 2015, 8:02 AM
wma_semihalf.com updated this object.Jul 27 2015, 8:04 AM
andrew edited edge metadata.Jul 27 2015, 2:51 PM

I'm not sure we need a goto in the loop, finding the next id is simple to do when we know we have a cpu node.

sys/dev/ofw/ofw_cpu.c
301–314
u_int next_id;
...
next_id = 0;
...
for (child = OF_child(node); child != 0; child = OF_peer(child), id = next_id) {
311
next_id++;
324

Then revert this

332

And this

336

etc.

wma_semihalf.com updated this revision to Diff 7424.Jul 28 2015, 8:09 AM
wma_semihalf.com edited edge metadata.
wma_semihalf.com removed rS FreeBSD src repository - subversion as the repository for this revision.
andrew accepted this revision.Jul 28 2015, 8:50 AM
andrew edited edge metadata.

Just need to fix the minor style issue before committing.

sys/dev/ofw/ofw_cpu.c
301

This line will need to be split as it was already at 80 characters.

This revision is now accepted and ready to land.Jul 28 2015, 8:50 AM
Closed by commit rS285957: Limit ofw_cpu_early_foreach() to CPUs only (authored by zbb). · Explain WhyJul 28 2015, 1:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
ofw/
19 lines

Diff 7424

View Options

sys/dev/ofw/ofw_cpu.c

Loading...