Differential D25208

net-mgmt/nsca-ng: Update to 1.6, now compiles on -12 and -13
ClosedPublic
Actions

Authored by knan-rfo_modirum.com on Jun 10 2020, 1:37 PM.

Tags

None

Referenced Files

	F102362714: D25208.diff
	Mon, Nov 11, 5:59 AM

	Unknown Object (File)
	Wed, Oct 30, 4:27 AM

	Unknown Object (File)
	Fri, Oct 18, 1:16 PM

	Unknown Object (File)
	Oct 3 2024, 6:11 PM

	Unknown Object (File)
	Oct 1 2024, 3:22 PM

	Unknown Object (File)
	Sep 29 2024, 9:45 PM

	Unknown Object (File)
	Sep 28 2024, 1:31 AM

	Unknown Object (File)
	Sep 26 2024, 11:41 PM

View All 66 Files

Subscribers

Details

Reviewers

pi
swills

Commits

rP541229: MFH: r541222
rP541222: net-mgmt/nsca-ng: Update to 1.6

Summary

nsca-ng development has moved to github. Refresh to version 1.6 from there.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

knan-rfo_modirum.com created this revision.Jun 10 2020, 1:37 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 10 2020, 1:37 PM

knan-rfo_modirum.com requested review of this revision.Jun 10 2020, 1:37 PM

Thanks for the patch.
You might be interested in using ports-mgmt/portlint and ports-mgmt/poudriere. These tools catch most if not all of the common pitfalls we face when updating ports.
You can have more information here:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#testing-poudriere
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-portlint

net-mgmt/nsca-ng/Makefile
2 ↗	(On Diff #72923)	The review patch doesn't apply cleanly for Makefile. The version in the repository already contains this line for example.
6 ↗	(On Diff #72923)	Delete since we are bumping PORTVERSION
8 ↗	(On Diff #72923)	Move up right after PORTVERSION
12 ↗	(On Diff #72923)	This should be after USES= Also GH_PROJECT can be deleted since it defaults to PORTNAME

Addressed review comments, now passes portlint, already passed poudriere testport.

Thanks for the review. Updated patch addresses these nits.

fernape added inline comments.Jun 11 2020, 1:55 PM

net-mgmt/nsca-ng/Makefile
44 ↗	(On Diff #72977)	WARN: Makefile: [43]: IGNORE messages should begin with a lowercase letter and end without a period.

Pre-existing warning before this patch, so a bit out of scope I feel. But I can of course fix it.

Fix remaining pre-existing portlint nits.

knan-rfo_modirum.com marked an inline comment as done.Jun 12 2020, 10:55 AM

Thanks for that!

Builds OK for {11.3,12.1}{amd64,i386} and 13-current

LGTM

Testbuilds are fine. fernape, are you going to commit this ?

This revision is now accepted and ready to land.Jul 4 2020, 12:01 PM

In D25208#565139, @pi wrote:

Testbuilds are fine. fernape, are you going to commit this ?

Sure thing. Thanks for reviewing this.

Closed by commit rP541222: net-mgmt/nsca-ng: Update to 1.6 (authored by fernape). · Explain WhyJul 4 2020, 4:03 PM

This revision was automatically updated to reflect the committed changes.

fernape added a commit: rP541222: net-mgmt/nsca-ng: Update to 1.6.

fernape added a commit: rP541229: MFH: r541222.Jul 4 2020, 6:01 PM

Revision Contents
Changeset List

Path

Size

head/

net-mgmt/

nsca-ng/

22 lines

5 lines

files/

patch-src_common_tls.c

20 lines

2 lines

Diff 74072

head/net-mgmt/nsca-ng/Makefile

Loading...

head/net-mgmt/nsca-ng/distinfo

Loading...

head/net-mgmt/nsca-ng/files/patch-src_common_tls.c

Loading...

head/net-mgmt/nsca-ng/pkg-descr

Loading...