Differential D25543

Fix page fault in zfsctl_snapdir_getattr
ClosedPublic
Actions

Authored by asomers on Jul 1 2020, 10:17 PM.

Details

Reviewers

avg

Commits

rS363485: MFC r362891:
rS363484: MFC r362891:
rS362891: Fix page fault in zfsctl_snapdir_getattr

Summary

Fix page fault in zfsctl_snapdir_getattr

Must acquire the z_teardown_lock before accessing the zfsvfs_t object. I
can't reproduce this panic on demand, but this looks like the correct
solution.

PR: 247668

Test Plan

The ZFS test suite

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 32104
Build 29621: arc lint + arc unit

Event Timeline

asomers created this revision.Jul 1 2020, 10:17 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptJul 1 2020, 10:17 PM

asomers requested review of this revision.Jul 1 2020, 10:17 PM

Harbormaster completed remote builds in B32104: Diff 74003.Jul 1 2020, 10:17 PM

Thank you!

This revision is now accepted and ready to land.Jul 2 2020, 5:12 AM

Closed by commit rS362891: Fix page fault in zfsctl_snapdir_getattr (authored by asomers). · Explain WhyJul 2 2020, 1:17 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS362891: Fix page fault in zfsctl_snapdir_getattr.

asomers added a commit: rS363484: MFC r362891:.Jul 24 2020, 5:45 PM

asomers added a commit: rS363485: MFC r362891:.Jul 24 2020, 5:56 PM

Revision Contents
Changeset List

Path

Size

sys/

cddl/

contrib/

opensolaris/

uts/

common/

fs/

zfs/

zfs_ctldir.c

3 lines

Diff 74003

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c

Fix page fault in zfsctl_snapdir_getattrClosedPublicActions