Page MenuHomeFreeBSD
Differential D25327

Fix a double unlock in vm_object_backing_collapse_wait().
ClosedPublic
Actions

Authored by markj on Jun 17 2020, 6:30 PM.
Tags
None
Referenced Files
F173361782: D25327.diff
Fri, Sep 25, 11:10 AM
Unknown Object (File)
Mon, Sep 14, 1:31 AM
Unknown Object (File)
Mon, Sep 14, 1:22 AM
Unknown Object (File)
Mon, Sep 7, 2:01 AM
Unknown Object (File)
Aug 26 2026, 10:35 AM
Unknown Object (File)
Aug 26 2026, 10:17 AM
Unknown Object (File)
Aug 24 2026, 4:14 AM
Unknown Object (File)
Aug 22 2026, 11:01 AM
View All Files
Subscribers
imp

Details

Reviewers
jeff
alc
kib
Commits
rS362360: Fix a double object unlock in vm_object_backing_collapse_wait().
Summary

vm_object_pip_sleep() will release the lock, I believe. I noticed this
by code inspection, so I'm not certain that this code is reachable.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31779
Build 29341: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jun 17 2020, 6:30 PM
markj created this revision.
markj added reviewers: jeff, alc, kib.Jun 17 2020, 6:42 PM
Harbormaster completed remote builds in B31779: Diff 73231.Jun 18 2020, 9:20 AM
kib accepted this revision.Jun 18 2020, 11:44 PM

It should be very hard to provoke this situation, but I believe it is real.

This revision is now accepted and ready to land.Jun 18 2020, 11:44 PM
Closed by commit rS362360: Fix a double object unlock in vm_object_backing_collapse_wait(). (authored by markj). · Explain WhyJun 19 2020, 3:32 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS362360: Fix a double object unlock in vm_object_backing_collapse_wait()..
Herald added a subscriber: imp. · View Herald TranscriptJun 19 2020, 3:32 AM

Revision Contents
Changeset List

PathSize
sys/
vm/
1 line

Diff 73231

View Options

sys/vm/vm_object.c

Loading...