Differential D25320

misc/xiphos: Update to 4.2.1
ClosedPublic
Actions

Authored by salvadore on Jun 17 2020, 1:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 10, 7:33 PM

	Unknown Object (File)
	Fri, May 10, 7:32 PM

	Unknown Object (File)
	Fri, May 10, 7:32 PM

	Unknown Object (File)
	Fri, May 10, 7:32 PM

	Unknown Object (File)
	Mon, May 6, 2:46 PM

	Unknown Object (File)
	Sat, May 4, 1:43 AM

	Unknown Object (File)
	Fri, May 3, 4:04 PM

	Unknown Object (File)
	Tue, Apr 30, 6:49 AM

View All 41 Files

Subscribers

Details

Reviewers

gerald
tcberner

Commits

rP539671: misc/xiphos: Update to 4.2.1

Summary

While here, also switch WWW to https.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31769
Build 29334: arc lint + arc unit

Event Timeline

salvadore created this revision.Jun 17 2020, 1:13 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 17 2020, 1:13 PM

salvadore requested review of this revision.Jun 17 2020, 1:13 PM

tcberner requested changes to this revision.Jun 17 2020, 1:25 PM

tcberner added inline comments.

head/misc/xiphos/Makefile
42	I don't quite understand the issue. Why are you not using the proper release tar ball which includes said file? https://github.com/crosswire/xiphos/releases/tag/4.2.1 e.g. xiphos-4.2.1.tar.xz

This revision now requires changes to proceed.Jun 17 2020, 1:25 PM

salvadore added inline comments.Jun 17 2020, 1:42 PM

head/misc/xiphos/Makefile
42	I could not find a way to get such file using USE_GITHUB. If it is possible to do it of course I would be glad to do it. Otherwise I think the choice is between: creating the missing the file manually; drop USE_GITHUB and manually specify MASTER_SITES and DISTFILES. I choosed the first solution as it looked cleaner to me.

Harbormaster completed remote builds in B31769: Diff 73221.Jun 18 2020, 9:19 AM

Use the release file instead of patching the sources downloaded with USE_GITHUB, as suggested by tcberner.

Harbormaster completed remote builds in B31807: Diff 73285.Jun 18 2020, 5:52 PM

I believe this is ready to land?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2020, 5:37 PM

Closed by commit rP539671: misc/xiphos: Update to 4.2.1 (authored by salvadore). · Explain Why

This revision was automatically updated to reflect the committed changes.

salvadore added a commit: rP539671: misc/xiphos: Update to 4.2.1.

Revision Contents
Changeset List

Path

Size

head/

misc/

xiphos/

15 lines

6 lines

2 lines

2 lines

Diff 73221

head/misc/xiphos/Makefile

Loading...

head/misc/xiphos/distinfo

Loading...

head/misc/xiphos/pkg-descr

Loading...

head/misc/xiphos/pkg-plist

Loading...